third_party/WebKit/LayoutTests/bluetooth/server/disconnect/detach-gc.html - Issue 2648583004: bluetooth: Stop firing value changed events after gatt disconnects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/bluetooth/server/disconnect/detach-gc.html

Issue 2648583004: bluetooth: Stop firing value changed events after gatt disconnects (Closed)

Patch Set: Make iframe subscribe to notifications and add comments. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/notification-after-disconnection.html ('k') | third_party/WebKit/LayoutTests/bluetooth/server/disconnect/gc-detach.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/bluetooth/server/disconnect/detach-gc.html

diff --git a/third_party/WebKit/LayoutTests/bluetooth/server/disconnect/detach-gc.html b/third_party/WebKit/LayoutTests/bluetooth/server/disconnect/detach-gc.html

index cab5e4ba6efaba4aa0a2ce85b5f687d426fa9038..7a8a5908410c8eabecd25d3986431010f1f6a869 100644

--- a/third_party/WebKit/LayoutTests/bluetooth/server/disconnect/detach-gc.html

+++ b/third_party/WebKit/LayoutTests/bluetooth/server/disconnect/detach-gc.html

@@ -10,7 +10,7 @@

if (messageEvent.data === 'Ready') {

let iframe = document.querySelector('iframe');

callWithKeyDown(() => {

- iframe.contentWindow.postMessage('Go', '*');

+ iframe.contentWindow.postMessage('RequestAndConnect', '*');

});

} else if (messageEvent.data === 'Connected') {

// Detach

@@ -25,7 +25,7 @@

setBluetoothFakeAdapter('HeartRateAdapter')

.then(() => {

let iframe = document.createElement('iframe');

- iframe.src = '../../../resources/bluetooth/connect-iframe.html';

+ iframe.src = '../../../resources/bluetooth/heart-rate-iframe.html';

document.body.appendChild(iframe);

});

}, 'Detach frame then garbage collect. We shouldn\'t crash.');