third_party/WebKit/LayoutTests/bluetooth/server/disconnect/detach-gc.html - Issue 2648583004: bluetooth: Stop firing value changed events after gatt disconnects

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/bluetooth/server/disconnect/detach-gc.html

Issue 2648583004: bluetooth: Stop firing value changed events after gatt disconnects (Closed)

Patch Set: Make iframe subscribe to notifications and add comments. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/notification-after-disconnection.html ('k') | third_party/WebKit/LayoutTests/bluetooth/server/disconnect/gc-detach.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../../resources/testharness.js"></script>	2 <script src="../../../resources/testharness.js"></script>

3 <script src="../../../resources/testharnessreport.js"></script>	3 <script src="../../../resources/testharnessreport.js"></script>

4 <script src="../../../resources/bluetooth/bluetooth-helpers.js"></script>	4 <script src="../../../resources/bluetooth/bluetooth-helpers.js"></script>

5 <body>	5 <body>

6 <script>	6 <script>

7 "use strict";	7 "use strict";

8 async_test(test => {	8 async_test(test => {

9 window.onmessage = messageEvent => test.step(() => {	9 window.onmessage = messageEvent => test.step(() => {

10 if (messageEvent.data === 'Ready') {	10 if (messageEvent.data === 'Ready') {

11 let iframe = document.querySelector('iframe');	11 let iframe = document.querySelector('iframe');

12 callWithKeyDown(() => {	12 callWithKeyDown(() => {

13 iframe.contentWindow.postMessage('Go', '*');	13 iframe.contentWindow.postMessage('RequestAndConnect', '*');

14 });	14 });

15 } else if (messageEvent.data === 'Connected') {	15 } else if (messageEvent.data === 'Connected') {

16 // Detach	16 // Detach

17 let iframe = document.querySelector('iframe');	17 let iframe = document.querySelector('iframe');

18 iframe.remove();	18 iframe.remove();

19 // GC	19 // GC

20 runGarbageCollection().then(() => test.done());	20 runGarbageCollection().then(() => test.done());

21 } else {	21 } else {

22 assert_unreached('iframe sent invalid data: ' + messageEvent.data);	22 assert_unreached('iframe sent invalid data: ' + messageEvent.data);

23 }	23 }

24 });	24 });

25 setBluetoothFakeAdapter('HeartRateAdapter')	25 setBluetoothFakeAdapter('HeartRateAdapter')

26 .then(() => {	26 .then(() => {

27 let iframe = document.createElement('iframe');	27 let iframe = document.createElement('iframe');

28 iframe.src = '../../../resources/bluetooth/connect-iframe.html';	28 iframe.src = '../../../resources/bluetooth/heart-rate-iframe.html';

29 document.body.appendChild(iframe);	29 document.body.appendChild(iframe);

30 });	30 });

31 }, 'Detach frame then garbage collect. We shouldn\'t crash.');	31 }, 'Detach frame then garbage collect. We shouldn\'t crash.');

32 </script>	32 </script>

33 </body>	33 </body>

OLD	NEW