Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2648543003: Android: Add no-op configs for hiding symbols by default (Closed)

Created:
3 years, 11 months ago by agrieve
Modified:
3 years, 11 months ago
Reviewers:
brettw, Torne
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Android: Add no-op configs for hiding symbols by default This is required so that ffmpeg and angle sub-projects can be updated to opt-out of the new default before it's actually enabled. Once they are updated & rolled, the configs will be filled in and //build/config/android:hide_native_jni_exports will go away. BUG=448386 Review-Url: https://codereview.chromium.org/2648543003 Cr-Commit-Position: refs/heads/master@{#445443} Committed: https://chromium.googlesource.com/chromium/src/+/bbc2ee9e4fc0b6f0c8bf8b8ec1c11ee159e7cc75

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M build/config/BUILDCONFIG.gn View 2 chunks +8 lines, -3 lines 0 comments Download
M build/config/android/BUILD.gn View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
agrieve
On 2017/01/19 22:24:11, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:brettw@chromium.org, mailto:torne@chromium.org Details of ...
3 years, 11 months ago (2017-01-19 22:25:44 UTC) #3
Torne
lgtm
3 years, 11 months ago (2017-01-20 11:55:07 UTC) #4
brettw
lgtm
3 years, 11 months ago (2017-01-23 18:33:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2648543003/1
3 years, 11 months ago (2017-01-23 18:46:53 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 19:53:42 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bbc2ee9e4fc0b6f0c8bf8b8ec1c1...

Powered by Google App Engine
This is Rietveld 408576698