Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issue 2648433008: Use explicit WebString conversions in LayoutTest related files (Closed)

Created:
3 years, 11 months ago by kinuko
Modified:
3 years, 11 months ago
Reviewers:
tkent
CC:
chromium-reviews, darin-cc_chromium.org, dcheng, einbinder+watch-test-runner_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, Peter Beverloo
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use explicit WebString conversions in LayoutTest related files As we're deprecating implicit conversions for WebString <-> string16 replace them with explicit methods. (See crbug.com/667131 for more details) BUG=667131 Review-Url: https://codereview.chromium.org/2648433008 Cr-Commit-Position: refs/heads/master@{#445314} Committed: https://chromium.googlesource.com/chromium/src/+/6addc13d7cb14eed79c7f3f742cc1724d15a41d3

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -56 lines) Patch
M components/test_runner/mock_grammar_check.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/test_runner/mock_spell_check.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/test_runner/spell_check_client.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M components/test_runner/web_view_test_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/test/render_view_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M content/test/layouttest_support.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/mock_webclipboard_impl.cc View 10 chunks +21 lines, -19 lines 0 comments Download
M content/test/test_blink_web_unit_test_support.cc View 4 chunks +19 lines, -17 lines 0 comments Download

Messages

Total messages: 20 (16 generated)
kinuko
Kent-san, could you review? (Mostly mechanical only)
3 years, 11 months ago (2017-01-23 00:12:49 UTC) #12
tkent
lgtm
3 years, 11 months ago (2017-01-23 00:16:37 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2648433008/40001
3 years, 11 months ago (2017-01-23 02:04:10 UTC) #17
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 02:08:10 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6addc13d7cb14eed79c7f3f742cc...

Powered by Google App Engine
This is Rietveld 408576698