Get frecon working with mustash.

Get frecon working with mustash.

This CL adds a mus specific ConsoleServiceProviderDelegate. It sends
IPCs to mus-ws to take and relinquish display control. This is
necessary because dbus and display management are not in the same
process anymore.

BUG=682804
Review-Url: https://codereview.chromium.org/2648433006
Cr-Commit-Position: refs/heads/master@{#445857}
Committed: https://chromium.googlesource.com/chromium/src/+/a653f8962715401e37ae038f4946e85ab6433d6d

[kylechar, 2017-01-24 15:19:05]

Patchset #2 (id:20001) has been deleted

[kylechar, 2017-01-24 15:20:53]

kylechar@chromium.org changed reviewers:
+ sky@chromium.org, tsepez@chromium.org

[kylechar, 2017-01-24 15:20:54]

+sky for everything minus security
+tsepez for security review (mojoms and manifests)

[Tom Sepez, 2017-01-24 17:09:22]

lgtm

[sky, 2017-01-24 18:59:03]

https://codereview.chromium.org/2648433006/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/dbus/mus_console_service_provider_delegate.h
(right):

https://codereview.chromium.org/2648433006/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/dbus/mus_console_service_provider_delegate.h:23: void
TakeDisplayOwnership(const UpdateOwnershipCallback& callback) override;
I'm not familiar with ConsoleServiceProvider::Delegate. Is ok that the callback
is async?

https://codereview.chromium.org/2648433006/diff/40001/content/public/app/mojo...
File content/public/app/mojo/content_browser_manifest.json (right):

https://codereview.chromium.org/2648433006/diff/40001/content/public/app/mojo...
content/public/app/mojo/content_browser_manifest.json:61: "ui": [ "browser" ]
You should put this in c/b/chrome_content_browser_manifest_overlay.json.

https://codereview.chromium.org/2648433006/diff/40001/services/ui/manifest.json
File services/ui/manifest.json (right):

https://codereview.chromium.org/2648433006/diff/40001/services/ui/manifest.js...
services/ui/manifest.json:21: "browser": [
I don't think the ui service should know about browser. How about calling this
display_controller?

[kylechar, 2017-01-24 19:17:31]

https://codereview.chromium.org/2648433006/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/dbus/mus_console_service_provider_delegate.h
(right):

https://codereview.chromium.org/2648433006/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/dbus/mus_console_service_provider_delegate.h:23: void
TakeDisplayOwnership(const UpdateOwnershipCallback& callback) override;
On 2017/01/24 18:59:03, sky wrote:
> I'm not familiar with ConsoleServiceProvider::Delegate. Is ok that the
callback
> is async?

Yep, DisplayConfigurator::TakeControl/RelinquishControl are async already so
thankfully this is easy.

https://codereview.chromium.org/2648433006/diff/40001/content/public/app/mojo...
File content/public/app/mojo/content_browser_manifest.json (right):

https://codereview.chromium.org/2648433006/diff/40001/content/public/app/mojo...
content/public/app/mojo/content_browser_manifest.json:61: "ui": [ "browser" ]
On 2017/01/24 18:59:03, sky wrote:
> You should put this in c/b/chrome_content_browser_manifest_overlay.json.

Done.

https://codereview.chromium.org/2648433006/diff/40001/services/ui/manifest.json
File services/ui/manifest.json (right):

https://codereview.chromium.org/2648433006/diff/40001/services/ui/manifest.js...
services/ui/manifest.json:21: "browser": [
On 2017/01/24 18:59:03, sky wrote:
> I don't think the ui service should know about browser. How about calling this
> display_controller?

Done.

[sky, 2017-01-24 21:59:09]

LGTM

[kylechar, 2017-01-24 21:59:32]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2017-01-24 21:59:32]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2648433006/#ps60001
(title: "Rebase and change manifests.")

[commit-bot: I haz the power, 2017-01-24 22:00:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 23:29:11]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1485295172386280,
"parent_rev": "a524dbf5bad0e4c8b479bb0b2915afed6d240d3d", "commit_rev":
"a653f8962715401e37ae038f4946e85ab6433d6d"}

[commit-bot: I haz the power, 2017-01-24 23:30:02]

Description was changed from

==========
Get frecon working with mustash.

This CL adds a mus specific ConsoleServiceProviderDelegate. It sends
IPCs to mus-ws to take and relinquish display control. This is
necessary because dbus and display management are not in the same
process anymore.

BUG=682804
==========

to

==========
Get frecon working with mustash.

This CL adds a mus specific ConsoleServiceProviderDelegate. It sends
IPCs to mus-ws to take and relinquish display control. This is
necessary because dbus and display management are not in the same
process anymore.

BUG=682804

Review-Url: https://codereview.chromium.org/2648433006
Cr-Commit-Position: refs/heads/master@{#445857}
Committed:
https://chromium.googlesource.com/chromium/src/+/a653f8962715401e37ae038f4946...
==========

[commit-bot: I haz the power, 2017-01-24 23:30:03]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/a653f8962715401e37ae038f4946...