Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2648433004: Merged: [tracing] Use locale independent writer for FP values. (Closed)

Created:
3 years, 11 months ago by alph
Modified:
3 years, 11 months ago
Reviewers:
Yang, Michael Hablich
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, ulan
Target Ref:
refs/pending/branch-heads/5.6
Project:
v8
Visibility:
Public.

Description

Merged: [tracing] Use locale independent writer for FP values. Revision: 51c5d913937272907d1cc83f72424bbd2846ca07 BUG=v8:5820 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2648433004 . Cr-Commit-Position: refs/branch-heads/5.6@{#83} Cr-Branched-From: bdd3886218dfe76e8560eb8a18401942452ae859-refs/heads/5.6.326@{#1} Cr-Branched-From: 879f6599eee6e1dfcbe9a24bf688b261c03e9558-refs/heads/master@{#41014} Committed: https://chromium.googlesource.com/v8/v8/+/357706d9c79a0a11219e5eafb9ff7dbed8b52b2b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M src/tracing/traced-value.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M test/cctest/test-traced-value.cc View 4 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
alph
3 years, 11 months ago (2017-01-19 17:54:58 UTC) #1
alph
NOTE: This script will no longer automatically update include/v8-version.h and create a tag. This is ...
3 years, 11 months ago (2017-01-19 17:55:00 UTC) #2
Michael Hablich
On 2017/01/19 17:55:00, alph wrote: > NOTE: This script will no longer automatically update include/v8-version.h ...
3 years, 11 months ago (2017-01-19 18:02:34 UTC) #4
alph
Committed patchset #1 (id:1) manually as 357706d9c79a0a11219e5eafb9ff7dbed8b52b2b.
3 years, 11 months ago (2017-01-19 18:04:00 UTC) #6
Yang
3 years, 11 months ago (2017-01-19 18:04:12 UTC) #7
Message was sent while issue was closed.
On 2017/01/19 18:02:34, Michael Hablich wrote:
> On 2017/01/19 17:55:00, alph wrote:
> > NOTE: This script will no longer automatically update include/v8-version.h
and
> > create a tag. This is done automatically by the autotag bot. Please call the
> > merge_to_branch.py with --help for more information.
> 
> Lgtm

lgtm

Powered by Google App Engine
This is Rietveld 408576698