Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Issue 2648433003: Convert PlatformEventController Timer to use Unspeced frame-based timer. (Closed)

Created:
3 years, 11 months ago by joelhockey
Modified:
3 years, 10 months ago
Reviewers:
haraken, sashab
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, mlamouri+watch-blink_chromium.org, tfarina, timvolodine, webcomponents-bugzilla_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert PlatformEventController Timer to use Unspeced frame-based timer. BUG=624694 Review-Url: https://codereview.chromium.org/2648433003 Cr-Commit-Position: refs/heads/master@{#447883} Committed: https://chromium.googlesource.com/chromium/src/+/084fdb4fa1dad8cddc9d09601a8c8c0e2e7b3e4f

Patch Set 1 #

Patch Set 2 : Convert PlatformEventController Timer to use Unspeced frame-based timer. #

Patch Set 3 : Convert PlatformEventController Timer to use Unspeced frame-based timer. #

Patch Set 4 : Convert PlatformEventController Timer to use Unspeced frame-based timer. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M third_party/WebKit/Source/core/frame/PlatformEventController.h View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/PlatformEventController.cpp View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 20 (10 generated)
joelhockey
Depends on https://codereview.chromium.org/2645813002
3 years, 11 months ago (2017-01-19 05:07:37 UTC) #2
sashab
Remove double newline in CL description :) Other than that lg*m :D
3 years, 11 months ago (2017-01-19 05:23:23 UTC) #3
joelhockey
On 2017/01/19 at 05:23:23, sashab wrote: > Remove double newline in CL description :) > ...
3 years, 11 months ago (2017-01-19 05:31:50 UTC) #5
joelhockey
3 years, 11 months ago (2017-01-19 13:07:41 UTC) #7
haraken
Is this ready for review? Or are you planning to pass in Frame* to PlatformEventController? ...
3 years, 11 months ago (2017-01-19 13:49:38 UTC) #8
joelhockey
On 2017/01/19 at 13:49:38, haraken wrote: > Is this ready for review? Or are you ...
3 years, 10 months ago (2017-02-02 00:03:26 UTC) #9
joelhockey
On 2017/02/02 at 00:03:26, joelhockey wrote: > On 2017/01/19 at 13:49:38, haraken wrote: > > ...
3 years, 10 months ago (2017-02-02 00:04:38 UTC) #10
haraken
On 2017/02/02 00:04:38, joelhockey wrote: > On 2017/02/02 at 00:03:26, joelhockey wrote: > > On ...
3 years, 10 months ago (2017-02-02 23:38:29 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2648433003/60001
3 years, 10 months ago (2017-02-02 23:40:11 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 23:46:21 UTC) #20
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/084fdb4fa1dad8cddc9d09601a8c...

Powered by Google App Engine
This is Rietveld 408576698