Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2648423004: Revert of Media Remoting: Don't exit remoting if no enough data buffered. (Closed)

Created:
3 years, 11 months ago by xjz
Modified:
3 years, 11 months ago
Reviewers:
miu
CC:
chromium-reviews, chromoting-reviews_chromium.org, feature-media-reviews_chromium.org, apacible+watch_chromium.org, xjz+watch_chromium.org, erickung+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Media Remoting: Don't exit remoting if no enough data buffered. (patchset #2 id:20001 of https://codereview.chromium.org/2648303003/ ) Reason for revert: I just realized that this BufferingState is reported from receiver side. So the BUFFERING_HAVE_NOTHING state could also be caused by insufficient bandwidth condition, and should exit remoting. Revert this CL for now, and will re-think this issue. Original issue's description: > Media Remoting: Don't exit remoting if no enough data buffered. > When there is not enough data buffered for rendering, remote playback > may be paused/delayed. Don't exit remoting in this case. > > BUG=684078 > > Review-Url: https://codereview.chromium.org/2648303003 > Cr-Commit-Position: refs/heads/master@{#445542} > Committed: https://chromium.googlesource.com/chromium/src/+/551abe8c8bf1d5276dd03e98615ceb928597d719 TBR=miu@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=684078 Review-Url: https://codereview.chromium.org/2648423004 Cr-Commit-Position: refs/heads/master@{#445609} Committed: https://chromium.googlesource.com/chromium/src/+/173b3a82f7abf9c1edcb430900191e8997b29329

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M media/remoting/remote_renderer_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M media/remoting/remote_renderer_impl.cc View 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
xjz
Created Revert of Media Remoting: Don't exit remoting if no enough data buffered.
3 years, 11 months ago (2017-01-24 02:13:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2648423004/1
3 years, 11 months ago (2017-01-24 02:15:10 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/173b3a82f7abf9c1edcb430900191e8997b29329
3 years, 11 months ago (2017-01-24 02:27:15 UTC) #6
miu
3 years, 11 months ago (2017-01-24 19:24:14 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698