Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2648393002: Adding a new feature to enable/disable parallel downloading (Closed)

Created:
3 years, 11 months ago by qinmin
Modified:
3 years, 11 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding a new feature to enable/disable parallel downloading will add the UI flag when more things are added BUG=644352 Review-Url: https://codereview.chromium.org/2648393002 Cr-Commit-Position: refs/heads/master@{#445975} Committed: https://chromium.googlesource.com/chromium/src/+/18268bbb2566da62040b06c46f370f9ed6ea8964

Patch Set 1 #

Patch Set 2 : make it a chromium feature #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/common/chrome_features.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/chrome_features.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
qinmin
PTAL
3 years, 11 months ago (2017-01-23 20:45:05 UTC) #2
David Trainor- moved to gerrit
lgtm
3 years, 11 months ago (2017-01-24 16:56:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2648393002/20001
3 years, 11 months ago (2017-01-24 20:37:25 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/199268)
3 years, 11 months ago (2017-01-24 20:56:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2648393002/20001
3 years, 11 months ago (2017-01-24 21:03:49 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/199295) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, ...
3 years, 11 months ago (2017-01-24 21:19:17 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2648393002/20001
3 years, 11 months ago (2017-01-25 07:30:05 UTC) #17
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 08:05:23 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/18268bbb2566da62040b06c46f37...

Powered by Google App Engine
This is Rietveld 408576698