Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 2648383007: [wasm] Decoding the names section should stop if there is a problem with locals. (Closed)

Created:
3 years, 11 months ago by ahaas
Modified:
3 years, 10 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Decoding the names section should stop if there is a problem with locals. First discovery by the names section fuzzer I think. During the decoding of the names of locals only ok() of the outer decoder was checked, not the ok() of the actual names section decoder. R=tizer@chromium.org BUG=chromium:684855 Review-Url: https://codereview.chromium.org/2648383007 Cr-Commit-Position: refs/heads/master@{#42880} Committed: https://chromium.googlesource.com/v8/v8/+/864799d3ebbaeb8d1d54192fe97c6dc30ecd3e66

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M src/wasm/decoder.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/wasm/module-decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/wasm/module-decoder-unittest.cc View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
ahaas
3 years, 11 months ago (2017-01-25 09:42:31 UTC) #1
ahaas
On 2017/01/25 at 09:42:31, ahaas wrote: > ping
3 years, 10 months ago (2017-02-01 09:00:45 UTC) #7
titzer
On 2017/02/01 09:00:45, ahaas wrote: > On 2017/01/25 at 09:42:31, ahaas wrote: > > > ...
3 years, 10 months ago (2017-02-01 15:35:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2648383007/1
3 years, 10 months ago (2017-02-02 08:10:44 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 08:38:42 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/864799d3ebbaeb8d1d54192fe97c6dc30ec...

Powered by Google App Engine
This is Rietveld 408576698