Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 2648383002: Revert of Fetch Finch seed during restore (Closed)

Created:
3 years, 11 months ago by jbudorick
Modified:
3 years, 11 months ago
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fetch Finch seed during restore (patchset #8 id:140001 of https://codereview.chromium.org/2627093009/ ) Reason for revert: Breaking analyze step on linux_android_rel_ng. Original issue's description: > Fetch Finch seed during restore > > Chrome will fetch a Finch seed during a normal first run, but since > may take some time it is only done if the FRE is displayed (hence > hiding the delay from the user. The Finch data is not backed up since > it would probably be out of date when restored. As a result there was > no Finch seed set on the first run following a restore. > > Fix this by fetching the finch seed during restore. > > This also moves fetching the Finch seed from an Android Service to a background thread (actually an AsyncTask) and gets rid of the no longer used ToS Service. > > BUG=679386 > BUG=680829 > > Review-Url: https://codereview.chromium.org/2627093009 > Cr-Commit-Position: refs/heads/master@{#445436} > Committed: https://chromium.googlesource.com/chromium/src/+/6b91ed876fd20ba96e4c1c008d056a0ed98788b6 TBR=bauerb@chromium.org,asvitkine@chromium.org,torne@chromium.org,dpranke@chromium.org,aberent@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=679386 Review-Url: https://codereview.chromium.org/2648383002 Cr-Commit-Position: refs/heads/master@{#445465} Committed: https://chromium.googlesource.com/chromium/src/+/5525b40703df34b46fd9c5b2244378dd1d4d52c9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+341 lines, -799 lines) Patch
M base/android/java/src/org/chromium/base/ThreadUtils.java View 1 chunk +0 lines, -5 lines 0 comments Download
M base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java View 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/android/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/android/java/AndroidManifest.xml View 1 chunk +17 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupAgent.java View 9 chunks +30 lines, -90 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitTaskRunner.java View 1 chunk +0 lines, -134 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/init/NativeInitializationController.java View 4 chunks +73 lines, -26 lines 0 comments Download
M chrome/android/java_sources.gni View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/ChromeBackupAgentTest.java View 9 chunks +23 lines, -61 lines 0 comments Download
D chrome/android/junit/src/org/chromium/chrome/browser/init/AsyncInitTaskRunnerTest.java View 1 chunk +0 lines, -121 lines 0 comments Download
M components/variations/android/BUILD.gn View 1 chunk +2 lines, -11 lines 0 comments Download
D components/variations/android/java/src/org/chromium/components/variations/firstrun/VariationsSeedFetcher.java View 1 chunk +0 lines, -199 lines 0 comments Download
A components/variations/android/java/src/org/chromium/components/variations/firstrun/VariationsSeedService.java View 1 chunk +169 lines, -0 lines 0 comments Download
A components/variations/android/java/src/org/chromium/components/variations/firstrun/VariationsSeedServiceLauncher.java View 1 chunk +27 lines, -0 lines 0 comments Download
D components/variations/android/junit/src/org/chromium/components/variations/firstrun/VariationsSeedFetcherTest.java View 1 chunk +0 lines, -132 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
jbudorick
Created Revert of Fetch Finch seed during restore
3 years, 11 months ago (2017-01-23 20:24:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2648383002/1
3 years, 11 months ago (2017-01-23 20:25:09 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 20:26:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5525b40703df34b46fd9c5b22443...

Powered by Google App Engine
This is Rietveld 408576698