Replace all the string literals in core/frame/ImageBitmap.cpp with constants

Replace all the string literals in core/frame/ImageBitmap.cpp with constants that are defined at the top.

BUG=682321
Review-Url: https://codereview.chromium.org/2648353011
Cr-Commit-Position: refs/heads/master@{#446474}
Committed: https://chromium.googlesource.com/chromium/src/+/9e23072c46b5a0f2260b58bb6f89d2c4f7fd49a0

[zakerinasab1, 2017-01-26 18:58:27]

Description was changed from

==========
Replace all the string literals in core/frame/ImageBitmap.cpp with constants

Replace all the string literals in core/frame/ImageBitmap.cpp with constants
that are defined at the top.

BUG=682321
==========

to

==========
Replace all the string literals in core/frame/ImageBitmap.cpp with constants
that are defined at the top.

BUG=682321
==========

[zakerinasab1, 2017-01-26 18:58:28]

zakerinasab@google.com changed reviewers:
+ dcheng@chromium.org, junov@chromium.org

[zakerinasab1, 2017-01-26 19:00:52]

zakerinasab@google.com changed reviewers:
+ zakerinasab@google.com

[zakerinasab1, 2017-01-26 19:00:52]

Patch set uploaded. PTAL. Thanks.

[dcheng, 2017-01-26 19:27:51]

LGTM with nit addressed

https://codereview.chromium.org/2648353011/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/ImageBitmap.cpp (right):

https://codereview.chromium.org/2648353011/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/ImageBitmap.cpp:24: const char* const
kImageOrientationFlipY = "flipY";
Nit: constexpr char kImageOrientationFlip = "...";

ditto for the rest

[zakerinasab1, 2017-01-26 20:48:43]

Comments addressed. New patch uploaded.

https://codereview.chromium.org/2648353011/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/ImageBitmap.cpp (right):

https://codereview.chromium.org/2648353011/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/ImageBitmap.cpp:24: const char* const
kImageOrientationFlipY = "flipY";
On 2017/01/26 19:27:51, dcheng wrote:
> Nit: constexpr char kImageOrientationFlip = "...";
> 
> ditto for the rest

Done.

[Justin Novosad, 2017-01-26 21:49:14]

lgtm 2

[zakerinasab1, 2017-01-26 21:49:55]

The CQ bit was checked by zakerinasab@google.com

[zakerinasab1, 2017-01-26 21:49:55]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2648353011/#ps20001
(title: "Addressing comments")

[commit-bot: I haz the power, 2017-01-26 21:50:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 22:44:43]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485467395011760,
"parent_rev": "42d8de0ce3d18a85197a8394be1d21f0aecb6d01", "commit_rev":
"9e23072c46b5a0f2260b58bb6f89d2c4f7fd49a0"}

[commit-bot: I haz the power, 2017-01-26 22:45:16]

Description was changed from

==========
Replace all the string literals in core/frame/ImageBitmap.cpp with constants
that are defined at the top.

BUG=682321
==========

to

==========
Replace all the string literals in core/frame/ImageBitmap.cpp with constants
that are defined at the top.

BUG=682321

Review-Url: https://codereview.chromium.org/2648353011
Cr-Commit-Position: refs/heads/master@{#446474}
Committed:
https://chromium.googlesource.com/chromium/src/+/9e23072c46b5a0f2260b58bb6f89...
==========

[commit-bot: I haz the power, 2017-01-26 22:45:17]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9e23072c46b5a0f2260b58bb6f89...