[wasm][asm.js] Permit ternary operator in asm.js returns in some cases.

[wasm][asm.js] Permit ternary operator in asm.js returns in some cases.

In practice, Emscripten seems to emit cond?+a:+b type return
expressions. This is not allowed by the spec or errata, but we need
to support it for compatibility.

Similar patterns with ints / signed, do not seem to be supported.

BUG=v8:5891
R=mtrofin@chromium.org,aseemgarg@chromium.org

Review-Url: https://codereview.chromium.org/2648353010
Cr-Commit-Position: refs/heads/master@{#42677}
Committed: https://chromium.googlesource.com/v8/v8/+/d0befa956f13b279a6e8dfdeb19eda8e5a14e9ca

[bradnelson, 2017-01-26 06:00:23]

The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 06:00:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bradn, 2017-01-26 06:02:08]

Description was changed from

==========
[wasm][asm.js] Permit ternary operator in asm.js returns in some cases.

In practice, Emscripten seems to emit cond?+a:+b type return
expressions. This is not allowed by the spec or errata, but we need
to support it for compatibility.

Similar patterns with ints / signed, do not seem to be supported.

BUG=v8:5891
==========

to

==========
[wasm][asm.js] Permit ternary operator in asm.js returns in some cases.

In practice, Emscripten seems to emit cond?+a:+b type return
expressions. This is not allowed by the spec or errata, but we need
to support it for compatibility.

Similar patterns with ints / signed, do not seem to be supported.

BUG=v8:5891
R=mtrofin@chromium.org,aseemgarg@chromium.org
==========

[bradn, 2017-01-26 06:02:08]

bradnelson@google.com changed reviewers:
+ ahaas@chromium.org, aseemgarg@chromium.org, titzer@chromium.org

[bradn, 2017-01-26 06:02:15]

bradnelson@google.com changed reviewers:
+ bradnelson@google.com

[commit-bot: I haz the power, 2017-01-26 06:31:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 06:31:33]

Dry run: This issue passed the CQ dry run.

[bradn, 2017-01-26 07:45:04]

bradnelson@google.com changed reviewers:
+ mtrofin@chromium.org

[bradn, 2017-01-26 07:45:42]

Oops, didn't match reviews and R=
Meant for mtrofin / aseemgarg to take a look.

[Mircea Trofin, 2017-01-26 07:47:27]

lgtm

https://codereview.chromium.org/2648353010/diff/1/src/asmjs/asm-typer.cc
File src/asmjs/asm-typer.cc (right):

https://codereview.chromium.org/2648353010/diff/1/src/asmjs/asm-typer.cc#newc...
src/asmjs/asm-typer.cc:2809: // Emscipten.
Emscripten

https://codereview.chromium.org/2648353010/diff/1/src/asmjs/asm-typer.cc#newc...
src/asmjs/asm-typer.cc:2811: AsmType* a;
init a and b?

[bradn, 2017-01-26 07:50:43]

https://codereview.chromium.org/2648353010/diff/1/src/asmjs/asm-typer.cc
File src/asmjs/asm-typer.cc (right):

https://codereview.chromium.org/2648353010/diff/1/src/asmjs/asm-typer.cc#newc...
src/asmjs/asm-typer.cc:2809: // Emscipten.
On 2017/01/26 07:47:27, Mircea Trofin wrote:
> Emscripten

Done.

https://codereview.chromium.org/2648353010/diff/1/src/asmjs/asm-typer.cc#newc...
src/asmjs/asm-typer.cc:2811: AsmType* a;
On 2017/01/26 07:47:27, Mircea Trofin wrote:
> init a and b?

Done.

[bradn, 2017-01-26 07:50:50]

The CQ bit was checked by bradnelson@google.com

[bradn, 2017-01-26 07:50:50]

The patchset sent to the CQ was uploaded after l-g-t-m from mtrofin@chromium.org
Link to the patchset: https://codereview.chromium.org/2648353010/#ps20001
(title: "fix")

[commit-bot: I haz the power, 2017-01-26 07:50:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 08:12:08]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485417050305860,
"parent_rev": "8bf52534f6bf86821a1589dcbcb7335052c1f94f", "commit_rev":
"d0befa956f13b279a6e8dfdeb19eda8e5a14e9ca"}

[commit-bot: I haz the power, 2017-01-26 08:12:12]

Description was changed from

==========
[wasm][asm.js] Permit ternary operator in asm.js returns in some cases.

In practice, Emscripten seems to emit cond?+a:+b type return
expressions. This is not allowed by the spec or errata, but we need
to support it for compatibility.

Similar patterns with ints / signed, do not seem to be supported.

BUG=v8:5891
R=mtrofin@chromium.org,aseemgarg@chromium.org
==========

to

==========
[wasm][asm.js] Permit ternary operator in asm.js returns in some cases.

In practice, Emscripten seems to emit cond?+a:+b type return
expressions. This is not allowed by the spec or errata, but we need
to support it for compatibility.

Similar patterns with ints / signed, do not seem to be supported.

BUG=v8:5891
R=mtrofin@chromium.org,aseemgarg@chromium.org

Review-Url: https://codereview.chromium.org/2648353010
Cr-Commit-Position: refs/heads/master@{#42677}
Committed:
https://chromium.googlesource.com/v8/v8/+/d0befa956f13b279a6e8dfdeb19eda8e5a1...
==========

[commit-bot: I haz the power, 2017-01-26 08:12:13]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/d0befa956f13b279a6e8dfdeb19eda8e5a1...