Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 2648353009: Tweak some of the commands in the "Updating clang-format binaries" doc (Closed)

Created:
3 years, 10 months ago by Dan Beam
Modified:
3 years, 10 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Tweak some of the commands in the "Updating clang-format binaries" doc R=scottmg@chromium.org BUG=none NOTRY=true Review-Url: https://codereview.chromium.org/2648353009 Cr-Commit-Position: refs/heads/master@{#446245} Committed: https://chromium.googlesource.com/chromium/src/+/b71beb8843deac62f26c8a0753fa5e8b16e63248

Patch Set 1 #

Patch Set 2 : 12->14 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M docs/updating_clang_format_binaries.md View 1 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Dan Beam
3 years, 10 months ago (2017-01-26 03:08:06 UTC) #1
scottmg
lgtm
3 years, 10 months ago (2017-01-26 03:12:04 UTC) #2
scottmg
Oh, maybe change 12.0 to 14.0 too while you're at it.
3 years, 10 months ago (2017-01-26 03:14:00 UTC) #3
Dan Beam
On 2017/01/26 03:14:00, scottmg wrote: > Oh, maybe change 12.0 to 14.0 too while you're ...
3 years, 10 months ago (2017-01-26 05:48:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2648353009/20001
3 years, 10 months ago (2017-01-26 05:48:49 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-01-26 05:53:17 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b71beb8843deac62f26c8a0753fa...

Powered by Google App Engine
This is Rietveld 408576698