Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: net/nqe/network_quality_estimator_params.cc

Issue 2648353003: Add effective connection type to throughput mapping (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/nqe/network_quality_estimator_params.cc
diff --git a/net/nqe/network_quality_estimator_params.cc b/net/nqe/network_quality_estimator_params.cc
index 28b873deef44b0981c577c708765f3431b0d7b41..10294264117f2344ccf54fc385e4a3fe97f3f995 100644
--- a/net/nqe/network_quality_estimator_params.cc
+++ b/net/nqe/network_quality_estimator_params.cc
@@ -232,30 +232,30 @@ void ObtainTypicalNetworkQuality(NetworkQuality typical_network_quality[]) {
}
typical_network_quality[EFFECTIVE_CONNECTION_TYPE_SLOW_2G] = NetworkQuality(
- // Set to the 83rd percentile of 2G RTT observations on Android. This
+ // Set to the 77.5th percentile of 2G RTT observations on Android. This
RyanSturm 2017/01/25 19:15:34 nit: 77.5th percentile sounds pretty weird to me.
tbansal1 2017/01/26 22:00:05 Seems like not super-important. I can call it perm
// corresponds to the median RTT observation when effective connection
// type is Slow 2G.
base::TimeDelta::FromMilliseconds(3600),
- base::TimeDelta::FromMilliseconds(3000), kInvalidThroughput);
+ base::TimeDelta::FromMilliseconds(3000), 40);
typical_network_quality[EFFECTIVE_CONNECTION_TYPE_2G] = NetworkQuality(
// Set to the 58th percentile of 2G RTT observations on Android. This
// corresponds to the median RTT observation when effective connection
// type is 2G.
base::TimeDelta::FromMilliseconds(1800),
- base::TimeDelta::FromMilliseconds(1500), kInvalidThroughput);
+ base::TimeDelta::FromMilliseconds(1500), 75);
typical_network_quality[EFFECTIVE_CONNECTION_TYPE_3G] = NetworkQuality(
// Set to the 75th percentile of 3G RTT observations on Android. This
// corresponds to the median RTT observation when effective connection
// type is 3G.
base::TimeDelta::FromMilliseconds(450),
- base::TimeDelta::FromMilliseconds(400), kInvalidThroughput);
+ base::TimeDelta::FromMilliseconds(400), 400);
// Set to the 25th percentile of 3G RTT observations on Android.
- typical_network_quality[EFFECTIVE_CONNECTION_TYPE_4G] = NetworkQuality(
- base::TimeDelta::FromMilliseconds(175),
- base::TimeDelta::FromMilliseconds(125), kInvalidThroughput);
+ typical_network_quality[EFFECTIVE_CONNECTION_TYPE_4G] =
+ NetworkQuality(base::TimeDelta::FromMilliseconds(175),
+ base::TimeDelta::FromMilliseconds(125), 1600);
static_assert(
EFFECTIVE_CONNECTION_TYPE_4G + 1 == EFFECTIVE_CONNECTION_TYPE_LAST,

Powered by Google App Engine
This is Rietveld 408576698