Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2648323013: MD Settings: use preprocess=true instead of flattenhtml=true in more places (Closed)

Created:
3 years, 10 months ago by Dan Beam
Modified:
3 years, 10 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: use preprocess=true instead of flattenhtml=true in more places This reduces the chance of inlinine resources before vulcanize can have a crack at is. R=dpapad@chromium.org BUG=673825 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2648323013 Cr-Commit-Position: refs/heads/master@{#447048} Committed: https://chromium.googlesource.com/chromium/src/+/81fb30fb5ab5c4142b1a3f8fbed7af51ae9b7bef

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -54 lines) Patch
M chrome/browser/resources/settings/settings_resources.grd View 38 chunks +54 lines, -54 lines 2 comments Download

Messages

Total messages: 15 (9 generated)
Dan Beam
https://codereview.chromium.org/2648323013/diff/1/chrome/browser/resources/settings/settings_resources.grd File chrome/browser/resources/settings/settings_resources.grd (right): https://codereview.chromium.org/2648323013/diff/1/chrome/browser/resources/settings/settings_resources.grd#newcode653 chrome/browser/resources/settings/settings_resources.grd:653: flattenhtml="true" intentional https://codereview.chromium.org/2648323013/diff/1/chrome/browser/resources/settings/settings_resources.grd#newcode788 chrome/browser/resources/settings/settings_resources.grd:788: flattenhtml="true" intentional
3 years, 10 months ago (2017-01-27 23:38:39 UTC) #2
dpapad
lgtm
3 years, 10 months ago (2017-01-28 00:19:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2648323013/1
3 years, 10 months ago (2017-01-28 00:23:04 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/380039)
3 years, 10 months ago (2017-01-28 01:43:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2648323013/1
3 years, 10 months ago (2017-01-30 18:57:24 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 20:16:54 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/81fb30fb5ab5c4142b1a3f8fbed7...

Powered by Google App Engine
This is Rietveld 408576698