Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2648323006: Use update_w3c_test_expectations directly in same process. (Closed)

Created:
3 years, 11 months ago by qyearsley
Modified:
3 years, 11 months ago
Reviewers:
jeffcarp
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use update_w3c_test_expectations directly in same process. Reason: When debugging auto-import failures (e.g. http://crbug.com/684637), it may be helpful to know more about what the baseline/expectation update step was trying to do. This CL would make it so that new expectations and baselines would be logged. This also simplifies the way that things are run a little, since the expectation and baseline-updating step doesn't need to be run in a separate process. This change is consistent with the recent change to make it so that the TestImporter code is run in the same process rather than invoked as a sub-process. Review-Url: https://codereview.chromium.org/2648323006 Cr-Commit-Position: refs/heads/master@{#445834} Committed: https://chromium.googlesource.com/chromium/src/+/025a9d1cef4af3a58cb95db3fc9363e1c1a39501

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations.py View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
qyearsley
3 years, 11 months ago (2017-01-24 18:57:15 UTC) #4
jeffcarp
lgtm
3 years, 11 months ago (2017-01-24 19:50:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2648323006/1
3 years, 11 months ago (2017-01-24 22:05:25 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 22:13:54 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/025a9d1cef4af3a58cb95db3fc93...

Powered by Google App Engine
This is Rietveld 408576698