Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2648293002: Store the distilled_url in Reading List entry in Reading List on iOS. (Closed)

Created:
3 years, 11 months ago by Olivier
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Store the distilled_url in Reading List entry in Reading List on iOS. The URL of the distilled page is not necessarily the URL of the Reading List entry (in case of redirection). Store the URL of the page that was distilled in the database. This CL adds the field in ReadingListEntry. This field will be used in a next CL. BUG=682666 Review-Url: https://codereview.chromium.org/2647763005 Cr-Commit-Position: refs/heads/master@{#445063} (cherry picked from commit 695d0c65669b7af00f8daec96d497519c0e0cb46) Review-Url: https://codereview.chromium.org/2648293002 . Cr-Commit-Position: refs/branch-heads/2987@{#21} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/7a16a5ed6f3cc1d871b550ed0187695c0c6cba2c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -36 lines) Patch
M components/reading_list/ios/proto/reading_list.proto View 1 chunk +1 line, -0 lines 0 comments Download
M components/reading_list/ios/reading_list_entry.h View 3 chunks +7 lines, -3 lines 0 comments Download
M components/reading_list/ios/reading_list_entry.cc View 11 chunks +24 lines, -3 lines 0 comments Download
M components/reading_list/ios/reading_list_entry_unittest.cc View 4 chunks +11 lines, -4 lines 0 comments Download
M components/reading_list/ios/reading_list_model.h View 1 chunk +8 lines, -2 lines 0 comments Download
M components/reading_list/ios/reading_list_model_impl.h View 1 chunk +3 lines, -2 lines 0 comments Download
M components/reading_list/ios/reading_list_model_impl.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M components/reading_list/ios/reading_list_model_unittest.mm View 17 chunks +36 lines, -9 lines 0 comments Download
M ios/chrome/browser/reading_list/reading_list_download_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/reading_list/reading_list_web_state_observer_unittest.mm View 4 chunks +13 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Olivier
3 years, 11 months ago (2017-01-23 15:21:27 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7a16a5ed6f3cc1d871b550ed0187695c0c6cba2c.

Powered by Google App Engine
This is Rietveld 408576698