Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2648253006:
[DevTools] Hide empty toolbars (Closed)
|
Created:
3 years, 11 months ago by eostroukhov Modified:
3 years, 11 months ago Reviewers:
dgozman CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[DevTools] Hide empty toolbars
BUG=684608
Review-Url: https://codereview.chromium.org/2648253006
Cr-Commit-Position: refs/heads/master@{#445816}
Committed: https://chromium.googlesource.com/chromium/src/+/101119dce96e25e0ebb5ebce59de2c5a274ae95f
Patch Set 1 #
Total comments: 2
Patch Set 2 : [DevTools] Hide empty toolbars #Messages
Total messages: 19 (11 generated)
The CQ bit was checked by eostroukhov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
eostroukhov@chromium.org changed reviewers: + dgozman@chromium.org
Please take a look.
https://codereview.chromium.org/2648253006/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js (right): https://codereview.chromium.org/2648253006/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js:362: setVisible(visible) { Don't introduce a method for this, since toolbar doesn't do anything special. Instead, toggle the class directly in the client.
The CQ bit was checked by eostroukhov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Thanks for the review. New version uploaded, please take another look. https://codereview.chromium.org/2648253006/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js (right): https://codereview.chromium.org/2648253006/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js:362: setVisible(visible) { On 2017/01/24 17:32:14, dgozman wrote: > Don't introduce a method for this, since toolbar doesn't do anything special. > Instead, toggle the class directly in the client. Done.
lgtm
The CQ bit was unchecked by eostroukhov@chromium.org
The CQ bit was checked by eostroukhov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by eostroukhov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485286920798670,
"parent_rev": "eb52fcf8c84eb033f63d2839eb8805eb9ec137fe", "commit_rev":
"101119dce96e25e0ebb5ebce59de2c5a274ae95f"}
Message was sent while issue was closed.
Description was changed from ========== [DevTools] Hide empty toolbars BUG=684608 ========== to ========== [DevTools] Hide empty toolbars BUG=684608 Review-Url: https://codereview.chromium.org/2648253006 Cr-Commit-Position: refs/heads/master@{#445816} Committed: https://chromium.googlesource.com/chromium/src/+/101119dce96e25e0ebb5ebce59de... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/101119dce96e25e0ebb5ebce59de... |
