Cleanup: remove state variables from inline_algorithm

Cleanup: remove state variables from inline_algorithm

BUG=635619
Review-Url: https://codereview.chromium.org/2648253005
Cr-Commit-Position: refs/heads/master@{#445586}
Committed: https://chromium.googlesource.com/chromium/src/+/9a539bd604e4a8c6aed45356afc1cb1df3b35c37

[atotic, 2017-01-23 23:17:37]

atotic@chromium.org changed reviewers:
+ ikilpatrick@chromium.org

[atotic, 2017-01-23 23:17:44]

ptal

[ikilpatrick, 2017-01-23 23:21:36]

https://codereview.chromium.org/2648253005/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/ng/ng_inline_layout_algorithm.cc
(left):

https://codereview.chromium.org/2648253005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_inline_layout_algorithm.cc:40: 
my newlines /o\!

https://codereview.chromium.org/2648253005/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/ng/ng_inline_layout_algorithm.h
(right):

https://codereview.chromium.org/2648253005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_inline_layout_algorithm.h:47: bool
LayoutCurrentChild();
can you remove this? i forgot to in an earlier patch.

https://codereview.chromium.org/2648253005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_inline_layout_algorithm.h:48:
NGConstraintSpace* CreateConstraintSpaceForCurrentChild(
can you rename this to:
CreateConstraintSpaceForChild(const NGInlineNode& child)
?

[atotic, 2017-01-23 23:31:21]

ptal

https://codereview.chromium.org/2648253005/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/ng/ng_inline_layout_algorithm.cc
(left):

https://codereview.chromium.org/2648253005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_inline_layout_algorithm.cc:40: 
On 2017/01/23 at 23:21:36, ikilpatrick wrote:
> my newlines /o\!

done. newline is back.

https://codereview.chromium.org/2648253005/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/ng/ng_inline_layout_algorithm.h
(right):

https://codereview.chromium.org/2648253005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_inline_layout_algorithm.h:47: bool
LayoutCurrentChild();
On 2017/01/23 at 23:21:36, ikilpatrick wrote:
> can you remove this? i forgot to in an earlier patch.

done

https://codereview.chromium.org/2648253005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_inline_layout_algorithm.h:48:
NGConstraintSpace* CreateConstraintSpaceForCurrentChild(
On 2017/01/23 at 23:21:36, ikilpatrick wrote:
> can you rename this to:
> CreateConstraintSpaceForChild(const NGInlineNode& child)
> ?

done

[ikilpatrick, 2017-01-23 23:39:17]

lgtm, thanks.

[atotic, 2017-01-23 23:40:21]

The CQ bit was checked by atotic@chromium.org

[commit-bot: I haz the power, 2017-01-23 23:40:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 01:46:22]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485214821067660,
"parent_rev": "56cee024237174f6a5a6281fa534bc3874aee8ef", "commit_rev":
"9a539bd604e4a8c6aed45356afc1cb1df3b35c37"}

[commit-bot: I haz the power, 2017-01-24 01:46:57]

Description was changed from

==========
Cleanup: remove state variables from inline_algorithm

BUG=635619
==========

to

==========
Cleanup: remove state variables from inline_algorithm

BUG=635619

Review-Url: https://codereview.chromium.org/2648253005
Cr-Commit-Position: refs/heads/master@{#445586}
Committed:
https://chromium.googlesource.com/chromium/src/+/9a539bd604e4a8c6aed45356afc1...
==========

[commit-bot: I haz the power, 2017-01-24 01:46:58]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9a539bd604e4a8c6aed45356afc1...