Use default_args for configuring V8

Use default_args for configuring V8.

Removes the values in build_overrides/v8.gni and uses the new default_args in
the "//.gn" file to set these arguments.

Once all places are updated, we can remove build_overrides/v8.gni.

BUG=684096
Review-Url: https://codereview.chromium.org/2648233006
Cr-Commit-Position: refs/heads/master@{#446124}
Committed: https://chromium.googlesource.com/chromium/src/+/04a0e487ece54c7e1568f53e3dc8b247dcf6ca74

[brettw, 2017-01-25 20:19:29]

brettw@chromium.org changed reviewers:
+ machenbach@chromium.org

[brettw, 2017-01-25 20:19:33]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 20:20:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brettw, 2017-01-25 20:40:21]

Description was changed from

==========
Use default_args for configuring VB.

Removes the values in build_overrides/v8.gni and uses the new default_args in
the "//.gn" file to set these arguments.

Once all places are updated, we can remove build_overrides/v8.gni.

BUG=684096
==========

to

==========
Use default_args for configuring V8.

Removes the values in build_overrides/v8.gni and uses the new default_args in
the "//.gn" file to set these arguments.

Once all places are updated, we can remove build_overrides/v8.gni.

BUG=684096
==========

[Michael Achenbach, 2017-01-25 21:15:26]

lgtm

[brettw, 2017-01-25 21:19:46]

The CQ bit was unchecked by brettw@chromium.org

[brettw, 2017-01-25 21:19:50]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2017-01-25 21:20:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 21:30:05]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485379190540470, "parent_rev":
"c0ec080fc78b2603fb34598356652fe82dac9330", "commit_rev":
"04a0e487ece54c7e1568f53e3dc8b247dcf6ca74"}

[commit-bot: I haz the power, 2017-01-25 21:33:37]

Description was changed from

==========
Use default_args for configuring V8.

Removes the values in build_overrides/v8.gni and uses the new default_args in
the "//.gn" file to set these arguments.

Once all places are updated, we can remove build_overrides/v8.gni.

BUG=684096
==========

to

==========
Use default_args for configuring V8.

Removes the values in build_overrides/v8.gni and uses the new default_args in
the "//.gn" file to set these arguments.

Once all places are updated, we can remove build_overrides/v8.gni.

BUG=684096

Review-Url: https://codereview.chromium.org/2648233006
Cr-Commit-Position: refs/heads/master@{#446124}
Committed:
https://chromium.googlesource.com/chromium/src/+/04a0e487ece54c7e1568f53e3dc8...
==========

[commit-bot: I haz the power, 2017-01-25 21:33:38]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/04a0e487ece54c7e1568f53e3dc8...

[Adam Rice, 2017-01-26 03:59:00]

ricea@chromium.org changed reviewers:
+ ricea@chromium.org

[Adam Rice, 2017-01-26 03:59:01]

https://codereview.chromium.org/2648233006/diff/1/.gn
File .gn (right):

https://codereview.chromium.org/2648233006/diff/1/.gn#newcode27
.gn:27: "//third_party/WebKit/Source/core/streams/CommonStrings.js",
Is it safe to assume that nothing is going to come along and sort this list?

[Michael Achenbach, 2017-01-26 07:49:21]

https://codereview.chromium.org/2648233006/diff/1/.gn
File .gn (right):

https://codereview.chromium.org/2648233006/diff/1/.gn#newcode27
.gn:27: "//third_party/WebKit/Source/core/streams/CommonStrings.js",
On 2017/01/26 03:59:01, Adam Rice wrote:
> Is it safe to assume that nothing is going to come along and sort this list?

good question. Deferring to Brett

[sdefresne, 2017-01-26 11:06:26]

On 2017/01/26 07:49:21, Michael Achenbach wrote:
> https://codereview.chromium.org/2648233006/diff/1/.gn
> File .gn (right):
> 
> https://codereview.chromium.org/2648233006/diff/1/.gn#newcode27
> .gn:27: "//third_party/WebKit/Source/core/streams/CommonStrings.js",
> On 2017/01/26 03:59:01, Adam Rice wrote:
> > Is it safe to assume that nothing is going to come along and sort this list?
> 
> good question. Deferring to Brett

This is causing errors when target_os is set to "ios" as those variables are not
used. It appears to be a non-failure error though:

$ gn gen --args='target_os="ios"' out/xxx
ERROR at //.gn:24:28: Build argument has no effect.
  v8_extra_library_files = [
                           ^
The variable "v8_extra_library_files" was set as a build argument
but never appeared in a declare_args() block in any buildfile.

To view all possible args, run "gn args --list <builddir>"
Done. Made 2833 targets from 577 files in 1191ms

[mef, 2017-01-26 22:30:55]

On 2017/01/26 11:06:26, sdefresne wrote:
> On 2017/01/26 07:49:21, Michael Achenbach wrote:
> > https://codereview.chromium.org/2648233006/diff/1/.gn
> > File .gn (right):
> > 
> > https://codereview.chromium.org/2648233006/diff/1/.gn#newcode27
> > .gn:27: "//third_party/WebKit/Source/core/streams/CommonStrings.js",
> > On 2017/01/26 03:59:01, Adam Rice wrote:
> > > Is it safe to assume that nothing is going to come along and sort this
list?
> > 
> > good question. Deferring to Brett
> 
> This is causing errors when target_os is set to "ios" as those variables are
not
> used. It appears to be a non-failure error though:
> 
> $ gn gen --args='target_os="ios"' out/xxx
> ERROR at //.gn:24:28: Build argument has no effect.
>   v8_extra_library_files = [
>                            ^
> The variable "v8_extra_library_files" was set as a build argument
> but never appeared in a declare_args() block in any buildfile.
> 
> To view all possible args, run "gn args --list <builddir>"
> Done. Made 2833 targets from 577 files in 1191ms

I'm getting the same error while generating cronet project:

gn gen out/Debug-iphonesimulator --args='is_cronet_build=true
is_component_build=false  target_cpu="x64" target_os="ios"
enable_websockets=false disable_file_support=true disable_ftp_support=true
use_platform_icu_alternatives=true disable_brotli_filter=true
is_component_build=false ignore_elf32_limitations=true
use_partition_alloc=false' --ide=xcode 
ERROR at //.gn:34:41: Build argument has no effect.
  v8_experimental_extra_library_files = [
                                        ^
The variable "v8_experimental_extra_library_files" was set as a build argument
but never appeared in a declare_args() block in any buildfile.

Interestingly it didn't trigger failures on Cronet FYI builder:
https://build.chromium.org/p/chromium.fyi/builders/ios-simulator-cronet