[wasm] Change the constant kV8MaxWasmTableSize to a command line flag.

[wasm] Change the constant kV8MaxWasmTableSize to a command line flag.

Similar to the maximum memory size this limit caused problems for
the fuzzer due to oom issues. With the command line flag we can limit
the maximum table size for the fuzzer.

R=titzer@chromium.org

Review-Url: https://codereview.chromium.org/2648223004
Cr-Commit-Position: refs/heads/master@{#42623}
Committed: https://chromium.googlesource.com/v8/v8/+/d9253a2f7c6cc043e28fa26decd0d238ebd7ddd8

[ahaas, 2017-01-23 14:17:23]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-23 14:17:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 14:18:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 14:18:19]

Dry run: Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED, no build URL)

[titzer, 2017-01-23 18:35:00]

https://codereview.chromium.org/2648223004/diff/1/src/flag-definitions.h
File src/flag-definitions.h (right):

https://codereview.chromium.org/2648223004/diff/1/src/flag-definitions.h#newc...
src/flag-definitions.h:507: DEFINE_UINT(wasm_max_table_size, 10000000,
I think it'd be nicer if this used the value defined by wasm-limits.h. Is it
possible to do that by only including the wasm-limits.h file in the
flag-definitions.cc file? If so, then please do that.

Otherwise lgtm

https://codereview.chromium.org/2648223004/diff/1/src/wasm/wasm-limits.h
File src/wasm/wasm-limits.h (right):

https://codereview.chromium.org/2648223004/diff/1/src/wasm/wasm-limits.h#newc...
src/wasm/wasm-limits.h:20: // kV8MaxWasmMemoryPages is defined by
FLAG_wasm_max_mem_pages.
As per previous comment, please uncomment these. You can leave a comment to the
effect of "Please don't use this limit directly, but use the value of FLAG_..."

[ahaas, 2017-01-24 09:36:02]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 09:36:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ahaas, 2017-01-24 09:51:02]

On 2017/01/23 at 18:35:00, titzer wrote:
> https://codereview.chromium.org/2648223004/diff/1/src/flag-definitions.h
> File src/flag-definitions.h (right):
> 
>
https://codereview.chromium.org/2648223004/diff/1/src/flag-definitions.h#newc...
> src/flag-definitions.h:507: DEFINE_UINT(wasm_max_table_size, 10000000,
> I think it'd be nicer if this used the value defined by wasm-limits.h. Is it
possible to do that by only including the wasm-limits.h file in the
flag-definitions.cc file? If so, then please do that.
> 
> Otherwise lgtm
> 
> https://codereview.chromium.org/2648223004/diff/1/src/wasm/wasm-limits.h
> File src/wasm/wasm-limits.h (right):
> 
>
https://codereview.chromium.org/2648223004/diff/1/src/wasm/wasm-limits.h#newc...
> src/wasm/wasm-limits.h:20: // kV8MaxWasmMemoryPages is defined by
FLAG_wasm_max_mem_pages.
> As per previous comment, please uncomment these. You can leave a comment to
the effect of "Please don't use this limit directly, but use the value of
FLAG_..."

Done.

PTAL. Is this what you wanted? I added an include in flags.cc to wasm-limits.h
and use the constants from wasm-limits.h in flag-definitions.h.

[titzer, 2017-01-24 09:52:45]

On 2017/01/24 09:51:02, ahaas wrote:
> On 2017/01/23 at 18:35:00, titzer wrote:
> > https://codereview.chromium.org/2648223004/diff/1/src/flag-definitions.h
> > File src/flag-definitions.h (right):
> > 
> >
>
https://codereview.chromium.org/2648223004/diff/1/src/flag-definitions.h#newc...
> > src/flag-definitions.h:507: DEFINE_UINT(wasm_max_table_size, 10000000,
> > I think it'd be nicer if this used the value defined by wasm-limits.h. Is it
> possible to do that by only including the wasm-limits.h file in the
> flag-definitions.cc file? If so, then please do that.
> > 
> > Otherwise lgtm
> > 
> > https://codereview.chromium.org/2648223004/diff/1/src/wasm/wasm-limits.h
> > File src/wasm/wasm-limits.h (right):
> > 
> >
>
https://codereview.chromium.org/2648223004/diff/1/src/wasm/wasm-limits.h#newc...
> > src/wasm/wasm-limits.h:20: // kV8MaxWasmMemoryPages is defined by
> FLAG_wasm_max_mem_pages.
> > As per previous comment, please uncomment these. You can leave a comment to
> the effect of "Please don't use this limit directly, but use the value of
> FLAG_..."
> 
> Done.
> 
> PTAL. Is this what you wanted? I added an include in flags.cc to wasm-limits.h
> and use the constants from wasm-limits.h in flag-definitions.h.

Yep, LGTM.

[commit-bot: I haz the power, 2017-01-24 10:09:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 10:09:56]

Dry run: This issue passed the CQ dry run.

[ahaas, 2017-01-24 10:10:20]

The CQ bit was checked by ahaas@chromium.org

[commit-bot: I haz the power, 2017-01-24 10:10:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 10:12:22]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485252620079380,
"parent_rev": "e9b22dde28993cc116fbfc78e2ff3c836c8f6cad", "commit_rev":
"d9253a2f7c6cc043e28fa26decd0d238ebd7ddd8"}

[commit-bot: I haz the power, 2017-01-24 10:12:27]

Description was changed from

==========
[wasm] Change the constant kV8MaxWasmTableSize to a command line flag.

Similar to the maximum memory size this limit caused problems for
the fuzzer due to oom issues. With the command line flag we can limit
the maximum table size for the fuzzer.

R=titzer@chromium.org
==========

to

==========
[wasm] Change the constant kV8MaxWasmTableSize to a command line flag.

Similar to the maximum memory size this limit caused problems for
the fuzzer due to oom issues. With the command line flag we can limit
the maximum table size for the fuzzer.

R=titzer@chromium.org

Review-Url: https://codereview.chromium.org/2648223004
Cr-Commit-Position: refs/heads/master@{#42623}
Committed:
https://chromium.googlesource.com/v8/v8/+/d9253a2f7c6cc043e28fa26decd0d238ebd...
==========

[commit-bot: I haz the power, 2017-01-24 10:12:28]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/d9253a2f7c6cc043e28fa26decd0d238ebd...