Revert of Split BrowsingDataRemoverTest into two tests for Impl and Delegate.

Revert of Split BrowsingDataRemoverTest into two tests for Impl and Delegate. (patchset #3 id:40001 of https://codereview.chromium.org/2641853002/ )

Reason for revert:
Breaks the buildbot in ChromiumChromiumos on Linux ChromiumOS Full

Original issue's description:
> Split BrowsingDataRemoverTest into two tests for Impl and Delegate.
> 
> BrowsingDataRemoverImplTest will eventually be moved to content/ together
> with BrowsingDataRemoverImpl.
> 
> All tests and their helper classes have been moved to one or the other unittest
> based on whether the tested datatype is present in content/ or only in chrome/.
> 
> A few changes had to be made:
> - The *ImplTest class was converted to use BrowserContext instead of
>   TestingProfile, as it will use either BrowserContext or TestingBrowserContext
>   after it's moved to content/.
> - URLRequestContext is now retrieved through StoragePartition where it
>   originally was directly retrieved through TestingProfile. This is because
>   BrowserContext does not directly expose a GetURLRequestContext method.
> - The downloads test also tested the behavior of ChromeDownloadManagerDelegate.
>   As downloads are a content/ datatype, the main part of the test was moved
>   to *ImplTest, but a section testing ChromeDownloadManagerDelegate was moved
>   to *DelegateTest.
> 
> There are a few dependencies that were not yet removed in this CL, but will be
> removed in a followup:
> 1. *DelegateTest needs to see and be friend of BrowsingDataRemoverImpl to test
>    the usage of BrowsingDataFilterBuilder. To fix this, we need to improve
>    BrowsingDataFilterBuilder first
>    (uploaded as https://codereview.chromium.org/2647683002/).
> 2. *ImplTest refers to extensions, which are not known to content/. This is
>    caused by BrowsingDataHelper::EXTENSION mask which is respected in
>    StoragePartition deletions. To fix this, BrowsingDataHelper must be improved
>    first (also coming soon).
> 3. *ImplTest works with BrowsingContext, but needs to use a TestingProfile to
>    create an instance of BrowsingDataRemoverImpl. This is because the factory
>    does not accept a TestingBrowsingContext. This will be fixed naturally when
>    we move BrowsingDataRemoverImpl to content/ and replace the factory with
>    something like ::CreateFor(BrowsingContext*).
> 
> 
> BUG=668114
> 
> Review-Url: https://codereview.chromium.org/2641853002
> Cr-Commit-Position: refs/heads/master@{#445367}
> Committed: https://chromium.googlesource.com/chromium/src/+/29b98cde67e8350d241fad23847ef72fbb939de5

TBR=bauerb@chromium.org,msramek@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=668114
Review-Url: https://codereview.chromium.org/2648223003
Cr-Commit-Position: refs/heads/master@{#445370}
Committed: https://chromium.googlesource.com/chromium/src/+/e5dce61417dc3e705837e9bc90d14dacbb45c694

[jkrcal, 2017-01-23 13:10:57]

The CQ bit was checked by jkrcal@chromium.org

[jkrcal, 2017-01-23 13:10:57]

Created Revert of Split BrowsingDataRemoverTest into two tests for Impl and
Delegate.

[commit-bot: I haz the power, 2017-01-23 13:11:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 13:11:54]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485177057343080, "parent_rev":
"df762a58be5c19144ebb9930918ac1b0448378f7", "commit_rev":
"e5dce61417dc3e705837e9bc90d14dacbb45c694"}

[commit-bot: I haz the power, 2017-01-23 13:12:21]

Description was changed from

==========
Revert of Split BrowsingDataRemoverTest into two tests for Impl and Delegate.
(patchset #3 id:40001 of https://codereview.chromium.org/2641853002/ )

Reason for revert:
Breaks the buildbot in ChromiumChromiumos on Linux ChromiumOS Full

Original issue's description:
> Split BrowsingDataRemoverTest into two tests for Impl and Delegate.
> 
> BrowsingDataRemoverImplTest will eventually be moved to content/ together
> with BrowsingDataRemoverImpl.
> 
> All tests and their helper classes have been moved to one or the other
unittest
> based on whether the tested datatype is present in content/ or only in
chrome/.
> 
> A few changes had to be made:
> - The *ImplTest class was converted to use BrowserContext instead of
>   TestingProfile, as it will use either BrowserContext or
TestingBrowserContext
>   after it's moved to content/.
> - URLRequestContext is now retrieved through StoragePartition where it
>   originally was directly retrieved through TestingProfile. This is because
>   BrowserContext does not directly expose a GetURLRequestContext method.
> - The downloads test also tested the behavior of
ChromeDownloadManagerDelegate.
>   As downloads are a content/ datatype, the main part of the test was moved
>   to *ImplTest, but a section testing ChromeDownloadManagerDelegate was moved
>   to *DelegateTest.
> 
> There are a few dependencies that were not yet removed in this CL, but will be
> removed in a followup:
> 1. *DelegateTest needs to see and be friend of BrowsingDataRemoverImpl to test
>    the usage of BrowsingDataFilterBuilder. To fix this, we need to improve
>    BrowsingDataFilterBuilder first
>    (uploaded as https://codereview.chromium.org/2647683002/).
> 2. *ImplTest refers to extensions, which are not known to content/. This is
>    caused by BrowsingDataHelper::EXTENSION mask which is respected in
>    StoragePartition deletions. To fix this, BrowsingDataHelper must be
improved
>    first (also coming soon).
> 3. *ImplTest works with BrowsingContext, but needs to use a TestingProfile to
>    create an instance of BrowsingDataRemoverImpl. This is because the factory
>    does not accept a TestingBrowsingContext. This will be fixed naturally when
>    we move BrowsingDataRemoverImpl to content/ and replace the factory with
>    something like ::CreateFor(BrowsingContext*).
> 
> 
> BUG=668114
> 
> Review-Url: https://codereview.chromium.org/2641853002
> Cr-Commit-Position: refs/heads/master@{#445367}
> Committed:
https://chromium.googlesource.com/chromium/src/+/29b98cde67e8350d241fad23847e...

TBR=bauerb@chromium.org,msramek@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=668114
==========

to

==========
Revert of Split BrowsingDataRemoverTest into two tests for Impl and Delegate.
(patchset #3 id:40001 of https://codereview.chromium.org/2641853002/ )

Reason for revert:
Breaks the buildbot in ChromiumChromiumos on Linux ChromiumOS Full

Original issue's description:
> Split BrowsingDataRemoverTest into two tests for Impl and Delegate.
> 
> BrowsingDataRemoverImplTest will eventually be moved to content/ together
> with BrowsingDataRemoverImpl.
> 
> All tests and their helper classes have been moved to one or the other
unittest
> based on whether the tested datatype is present in content/ or only in
chrome/.
> 
> A few changes had to be made:
> - The *ImplTest class was converted to use BrowserContext instead of
>   TestingProfile, as it will use either BrowserContext or
TestingBrowserContext
>   after it's moved to content/.
> - URLRequestContext is now retrieved through StoragePartition where it
>   originally was directly retrieved through TestingProfile. This is because
>   BrowserContext does not directly expose a GetURLRequestContext method.
> - The downloads test also tested the behavior of
ChromeDownloadManagerDelegate.
>   As downloads are a content/ datatype, the main part of the test was moved
>   to *ImplTest, but a section testing ChromeDownloadManagerDelegate was moved
>   to *DelegateTest.
> 
> There are a few dependencies that were not yet removed in this CL, but will be
> removed in a followup:
> 1. *DelegateTest needs to see and be friend of BrowsingDataRemoverImpl to test
>    the usage of BrowsingDataFilterBuilder. To fix this, we need to improve
>    BrowsingDataFilterBuilder first
>    (uploaded as https://codereview.chromium.org/2647683002/).
> 2. *ImplTest refers to extensions, which are not known to content/. This is
>    caused by BrowsingDataHelper::EXTENSION mask which is respected in
>    StoragePartition deletions. To fix this, BrowsingDataHelper must be
improved
>    first (also coming soon).
> 3. *ImplTest works with BrowsingContext, but needs to use a TestingProfile to
>    create an instance of BrowsingDataRemoverImpl. This is because the factory
>    does not accept a TestingBrowsingContext. This will be fixed naturally when
>    we move BrowsingDataRemoverImpl to content/ and replace the factory with
>    something like ::CreateFor(BrowsingContext*).
> 
> 
> BUG=668114
> 
> Review-Url: https://codereview.chromium.org/2641853002
> Cr-Commit-Position: refs/heads/master@{#445367}
> Committed:
https://chromium.googlesource.com/chromium/src/+/29b98cde67e8350d241fad23847e...

TBR=bauerb@chromium.org,msramek@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=668114

Review-Url: https://codereview.chromium.org/2648223003
Cr-Commit-Position: refs/heads/master@{#445370}
Committed:
https://chromium.googlesource.com/chromium/src/+/e5dce61417dc3e705837e9bc90d1...
==========

[commit-bot: I haz the power, 2017-01-23 13:12:22]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e5dce61417dc3e705837e9bc90d1...