Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 2648213007: Revert "Use single InputPackagesResultProvider, without SdkSummaryResultProvider." (Closed)

Created:
3 years, 11 months ago by vsm
Modified:
3 years, 11 months ago
Reviewers:
scheglov
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Use single InputPackagesResultProvider, without SdkSummaryResultProvider." This reverts commit c9e1b888a3c72617eb727e31239760c3c617eff2. Revert "Remove parent from SummaryResynthesizer." This reverts commit 56726fcce00e912a5c8cd995f80be250b5376b3d. TBR=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/b701ad64530b500dc6e638cd4b9be716499f6a10

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -100 lines) Patch
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 3 chunks +0 lines, -9 lines 0 comments Download
M pkg/analyzer/lib/src/context/context.dart View 2 chunks +0 lines, -12 lines 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/sdk/sdk.dart View 2 chunks +4 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/generated/sdk_io.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/summary/package_bundle_reader.dart View 6 chunks +27 lines, -14 lines 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 10 chunks +61 lines, -22 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summary_sdk.dart View 3 chunks +80 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_ast_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_common.dart View 3 chunks +6 lines, -10 lines 0 comments Download
M pkg/analyzer_cli/lib/src/driver.dart View 3 chunks +2 lines, -10 lines 0 comments Download
M pkg/dev_compiler/lib/src/compiler/compiler.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/incremental_resolved_ast_generator_impl.dart View 4 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
vsm
Committed patchset #1 (id:1) manually as b701ad64530b500dc6e638cd4b9be716499f6a10 (presubmit successful).
3 years, 11 months ago (2017-01-24 14:21:50 UTC) #2
scheglov
3 years, 11 months ago (2017-01-24 14:55:13 UTC) #3
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698