Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: pkg/analyzer/test/src/summary/resynthesize_common.dart

Issue 2648213007: Revert "Use single InputPackagesResultProvider, without SdkSummaryResultProvider." (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/test/src/summary/resynthesize_ast_test.dart ('k') | pkg/analyzer_cli/lib/src/driver.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/src/summary/resynthesize_common.dart
diff --git a/pkg/analyzer/test/src/summary/resynthesize_common.dart b/pkg/analyzer/test/src/summary/resynthesize_common.dart
index 5eaf53a257ea2ff2192313d1401f94702966346a..916ea5aaab2f439420506d76f9b71e09eb6b8c0e 100644
--- a/pkg/analyzer/test/src/summary/resynthesize_common.dart
+++ b/pkg/analyzer/test/src/summary/resynthesize_common.dart
@@ -146,7 +146,7 @@ abstract class AbstractResynthesizeTest extends AbstractSingleUnitTest {
TestSummaryResynthesizer resynthesizer, LibraryElement library) {
// Check that no other summaries needed to be resynthesized to resynthesize
// the library element.
- expect(resynthesizer.resynthesisCount, 3);
+ expect(resynthesizer.resynthesisCount, 1);
// Check that the only linked summary consulted was that for [uri].
expect(resynthesizer.linkedSummariesRequested, hasLength(1));
expect(resynthesizer.linkedSummariesRequested.first,
@@ -4888,7 +4888,7 @@ var x;''');
checkMinimalResynthesisWork(resynthesizer, original.library);
// Check that no other summaries needed to be resynthesized to resynthesize
// the library element.
- expect(resynthesizer.resynthesisCount, 3);
+ expect(resynthesizer.resynthesisCount, 1);
expect(result.location, location);
return result;
}
@@ -4911,14 +4911,10 @@ class TestSummaryResynthesizer extends SummaryResynthesizer {
*/
final Set<String> linkedSummariesRequested = new Set<String>();
- TestSummaryResynthesizer(AnalysisContext context, this.unlinkedSummaries,
- this.linkedSummaries, this.allowMissingFiles)
- : super(context, context.sourceFactory,
- context.analysisOptions.strongMode) {
- // Clear after resynthesizing TypeProvider in super().
- unlinkedSummariesRequested.clear();
- linkedSummariesRequested.clear();
- }
+ TestSummaryResynthesizer(SummaryResynthesizer parent, AnalysisContext context,
+ this.unlinkedSummaries, this.linkedSummaries, this.allowMissingFiles)
+ : super(parent, context, context.typeProvider, context.sourceFactory,
+ context.analysisOptions.strongMode);
@override
LinkedLibrary getLinkedSummary(String uri) {
« no previous file with comments | « pkg/analyzer/test/src/summary/resynthesize_ast_test.dart ('k') | pkg/analyzer_cli/lib/src/driver.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698