Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 2648213002: mus: Use a barebone mus client-lib in chrome-renderer. (Closed)

Created:
3 years, 11 months ago by sadrul
Modified:
3 years, 11 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, site-isolation-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mus: Use a barebone mus client-lib in chrome-renderer. Notable changes: . Add RendererWindowTreeClient that implements ui.mojom.WindowTreeClient interface for chrome-renderer. It currently supports the most basic functionalities. For example, it does not receive events (the events instead are routed through chrome-browser), it does not support more than one window, window state changes (e.g. bounds, visibility etc.) are ignored (the corresponding messages from chrome-browser are used instead) etc. Over time however, this implementation will grow. . When chrome-renderer is running as a mus-client, it immediately creates a RendererWindowTreeClient instance for a RenderWidget, instead of waiting for a creation request from chrome-browser. . Remove RenderWidgetMusConnection, since it's no longer needed. BUG=672913 Review-Url: https://codereview.chromium.org/2648213002 Cr-Commit-Position: refs/heads/master@{#446257} Committed: https://chromium.googlesource.com/chromium/src/+/602ce136fcac0b2a338a5708f857cf12f8a77467

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Total comments: 8

Patch Set 7 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+396 lines, -141 lines) Patch
M content/renderer/mus/BUILD.gn View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
D content/renderer/mus/render_widget_mus_connection.h View 1 2 3 4 1 chunk +0 lines, -60 lines 0 comments Download
D content/renderer/mus/render_widget_mus_connection.cc View 1 2 3 4 1 chunk +0 lines, -65 lines 0 comments Download
M content/renderer/mus/render_widget_window_tree_client_factory.cc View 1 2 3 2 chunks +2 lines, -4 lines 0 comments Download
A content/renderer/mus/renderer_window_tree_client.h View 1 2 3 4 5 6 1 chunk +153 lines, -0 lines 0 comments Download
A content/renderer/mus/renderer_window_tree_client.cc View 1 2 3 4 5 6 1 chunk +225 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 3 2 chunks +7 lines, -8 lines 0 comments Download
M content/renderer/render_widget.cc View 1 2 3 4 5 6 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 55 (31 generated)
sadrul
3 years, 11 months ago (2017-01-24 01:51:45 UTC) #14
Fady Samuel
https://codereview.chromium.org/2648213002/diff/100001/content/renderer/mus/renderer_window_tree_client.cc File content/renderer/mus/renderer_window_tree_client.cc (right): https://codereview.chromium.org/2648213002/diff/100001/content/renderer/mus/renderer_window_tree_client.cc#newcode127 content/renderer/mus/renderer_window_tree_client.cc:127: NOTIMPLEMENTED(); We would get to here when an OOPIF ...
3 years, 11 months ago (2017-01-24 02:04:38 UTC) #15
Fady Samuel
This LGTM though. There's a bunch of work to do for OOPIF but we can ...
3 years, 11 months ago (2017-01-24 02:07:18 UTC) #16
sky
Nice! https://codereview.chromium.org/2648213002/diff/100001/content/renderer/mus/renderer_window_tree_client.h File content/renderer/mus/renderer_window_tree_client.h (right): https://codereview.chromium.org/2648213002/diff/100001/content/renderer/mus/renderer_window_tree_client.h#newcode28 content/renderer/mus/renderer_window_tree_client.h:28: class RendererWindowTreeClient : public ui::mojom::WindowTreeClient { Add description. ...
3 years, 11 months ago (2017-01-24 17:39:31 UTC) #19
sadrul
https://codereview.chromium.org/2648213002/diff/100001/content/renderer/mus/renderer_window_tree_client.cc File content/renderer/mus/renderer_window_tree_client.cc (right): https://codereview.chromium.org/2648213002/diff/100001/content/renderer/mus/renderer_window_tree_client.cc#newcode127 content/renderer/mus/renderer_window_tree_client.cc:127: NOTIMPLEMENTED(); On 2017/01/24 02:04:38, Fady Samuel wrote: > We ...
3 years, 11 months ago (2017-01-24 18:02:41 UTC) #22
sky
LGTM
3 years, 11 months ago (2017-01-24 18:13:48 UTC) #23
sadrul
+creis@ as content owner for render_widget.cc and render_thread_impl.cc changes.
3 years, 11 months ago (2017-01-24 18:22:22 UTC) #25
Charlie Reis
Sanity check: the new RendererWindowTreeClient class will work with OOPIFs, where the RenderWidget may be ...
3 years, 11 months ago (2017-01-24 21:21:45 UTC) #28
sadrul
On 2017/01/24 21:21:45, Charlie Reis wrote: > Sanity check: the new RendererWindowTreeClient class will work ...
3 years, 11 months ago (2017-01-24 21:41:17 UTC) #29
sadrul
On 2017/01/24 21:41:17, sadrul wrote: > On 2017/01/24 21:21:45, Charlie Reis wrote: > > Sanity ...
3 years, 11 months ago (2017-01-24 21:47:31 UTC) #30
Charlie Reis
[+dcheng, kenrb] On 2017/01/24 21:41:17, sadrul wrote: > On 2017/01/24 21:21:45, Charlie Reis wrote: > ...
3 years, 11 months ago (2017-01-24 21:53:16 UTC) #32
Charlie Reis
[+site-isolation-reviews]
3 years, 11 months ago (2017-01-24 21:53:41 UTC) #33
Charlie Reis
On 2017/01/24 21:47:31, sadrul wrote: > On 2017/01/24 21:41:17, sadrul wrote: > > On 2017/01/24 ...
3 years, 11 months ago (2017-01-24 21:55:59 UTC) #34
sadrul
On 2017/01/24 21:55:59, Charlie Reis wrote: > On 2017/01/24 21:47:31, sadrul wrote: > > On ...
3 years, 11 months ago (2017-01-25 01:09:33 UTC) #35
Charlie Reis
On 2017/01/25 01:09:33, sadrul wrote: > On 2017/01/24 21:55:59, Charlie Reis wrote: > > On ...
3 years, 11 months ago (2017-01-25 20:54:14 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2648213002/120001
3 years, 11 months ago (2017-01-25 21:15:10 UTC) #39
sadrul
On 2017/01/25 20:54:14, Charlie Reis wrote: > On 2017/01/25 01:09:33, sadrul wrote: > > On ...
3 years, 11 months ago (2017-01-25 21:31:05 UTC) #40
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/220327)
3 years, 11 months ago (2017-01-26 00:25:27 UTC) #42
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2648213002/120001
3 years, 11 months ago (2017-01-26 01:31:29 UTC) #44
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/350620)
3 years, 11 months ago (2017-01-26 01:36:01 UTC) #46
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2648213002/120001
3 years, 11 months ago (2017-01-26 01:55:08 UTC) #48
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/220541)
3 years, 11 months ago (2017-01-26 04:46:04 UTC) #50
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2648213002/120001
3 years, 11 months ago (2017-01-26 05:55:37 UTC) #52
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 06:42:13 UTC) #55
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/602ce136fcac0b2a338a5708f857...

Powered by Google App Engine
This is Rietveld 408576698