Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 2648203002: X87: [wasm] Fix I32ReinterpretF32 and I64ReinterpretF64 on ia32. (Closed)

Created:
3 years, 11 months ago by zhengxing.li
Modified:
3 years, 11 months ago
Reviewers:
chunyang.dai, ahaas
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [wasm] Fix I32ReinterpretF32 and I64ReinterpretF64 on ia32. port ea9254317149c7904a7bf6bc821af35958e4da7f (r42545) original commit message: On ia32 return statements in C++ automatically convert signalling NaNs to quiet NaNs, even when bit_cast is used. This CL removes all uses of bit_cast<float> and bit_cast<double> in the wasm compiler and wasm interpreter. BUG= Review-Url: https://codereview.chromium.org/2648203002 Cr-Commit-Position: refs/heads/master@{#42588} Committed: https://chromium.googlesource.com/v8/v8/+/66f2d7b64819676680be35e0fa0af4fa11da12cb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
zhengxing.li
PTAL, thanks!
3 years, 11 months ago (2017-01-23 07:11:48 UTC) #2
ahaas
lgtm
3 years, 11 months ago (2017-01-23 08:18:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2648203002/1
3 years, 11 months ago (2017-01-23 08:34:56 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/33066)
3 years, 11 months ago (2017-01-23 08:38:05 UTC) #7
chunyang.dai
On 2017/01/23 08:38:05, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 11 months ago (2017-01-23 08:41:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2648203002/1
3 years, 11 months ago (2017-01-23 08:41:59 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 08:56:59 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/66f2d7b64819676680be35e0fa0af4fa11d...

Powered by Google App Engine
This is Rietveld 408576698