Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 2648173002: Rename webmodule codegen bits to WebAgentAPI. (Closed)

Created:
3 years, 11 months ago by dglazkov
Modified:
3 years, 10 months ago
Reviewers:
haraken, bashi, Yuki
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename webmodule codegen bits to BlinkAPI. Replace all references to webmodules with new terminology. R=bashi,yukishiino BUG=683740 Review-Url: https://codereview.chromium.org/2648173002 Cr-Commit-Position: refs/heads/master@{#453040} Committed: https://chromium.googlesource.com/chromium/src/+/51630b914ab57d747101e9aa11433ea63fd36b43

Patch Set 1 #

Total comments: 3

Patch Set 2 : Changed to WebAgentAPI. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -482 lines) Patch
M third_party/WebKit/Source/bindings/IDLExtendedAttributes.txt View 1 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/bindings/scripts/code_generator_web_agent_api.py View 1 5 chunks +10 lines, -10 lines 0 comments Download
D third_party/WebKit/Source/bindings/scripts/code_generator_web_module.py View 1 1 chunk +0 lines, -190 lines 0 comments Download
A + third_party/WebKit/Source/bindings/scripts/code_generator_web_module_api_test.py View 1 3 chunks +5 lines, -5 lines 0 comments Download
D third_party/WebKit/Source/bindings/scripts/code_generator_web_module_test.py View 1 1 chunk +0 lines, -151 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/scripts.gni View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/templates/templates.gni View 1 1 chunk +26 lines, -25 lines 0 comments Download
A + third_party/WebKit/Source/bindings/templates/web_agent_api_interface.cc.tmpl View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/bindings/templates/web_agent_api_interface.h.tmpl View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/Source/bindings/templates/web_module_interface.cc.tmpl View 1 1 chunk +0 lines, -48 lines 0 comments Download
D third_party/WebKit/Source/bindings/templates/web_module_interface.h.tmpl View 1 1 chunk +0 lines, -46 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/idls/core/TestInterface3.idl View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/test_interface_3.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/test_interface_3.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/bindings/bindings_tests.py View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 25 (15 generated)
dglazkov
PTAL.
3 years, 11 months ago (2017-01-24 17:04:29 UTC) #7
haraken
"Blink API" sounds a bit too vague to me. For example, we have "public APIs" ...
3 years, 11 months ago (2017-01-24 21:00:22 UTC) #9
bashi
I'm fine with renaming. Defer to haraken@. https://codereview.chromium.org/2648173002/diff/1/third_party/WebKit/Source/bindings/scripts/scripts.gni File third_party/WebKit/Source/bindings/scripts/scripts.gni (right): https://codereview.chromium.org/2648173002/diff/1/third_party/WebKit/Source/bindings/scripts/scripts.gni#newcode44 third_party/WebKit/Source/bindings/scripts/scripts.gni:44: "code_generator_blink_api.py", alphabetical ...
3 years, 11 months ago (2017-01-25 23:57:14 UTC) #10
Yuki
I agree that "Blink API" is too vague, or unfriendly to code readers. [BlinkAPI] in ...
3 years, 11 months ago (2017-01-26 08:17:19 UTC) #11
dglazkov
Sounds good. Let me think about a better name. I agree that BlinkAPI is too ...
3 years, 10 months ago (2017-02-05 21:52:05 UTC) #12
dglazkov
Changed to WebAgentAPI.
3 years, 10 months ago (2017-02-25 00:05:53 UTC) #14
dglazkov
PTAL.
3 years, 10 months ago (2017-02-25 00:53:23 UTC) #17
haraken
LGTM
3 years, 10 months ago (2017-02-25 00:57:55 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2648173002/20001
3 years, 10 months ago (2017-02-25 01:42:44 UTC) #22
commit-bot: I haz the power
3 years, 10 months ago (2017-02-25 01:48:26 UTC) #25
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/51630b914ab57d747101e9aa1143...

Powered by Google App Engine
This is Rietveld 408576698