Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2648083002:
Migrate Timer to TaskRunnerTimer in InspectorNetworkAgent (Closed)
|
Created:
3 years, 11 months ago by Hwanseung Lee Modified:
3 years, 11 months ago Reviewers:
haraken CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMigrate Timer to TaskRunnerTimer in InspectorNetworkAgent
Migrate Timer to TaskRunnerTimer in InspectorNetworkAgent
Inspector is internal things. so it is not speced.
UnspecedLoading was choosed as TaskType.
because it is task about XHR.
BUG=624694
Review-Url: https://codereview.chromium.org/2648083002
Cr-Commit-Position: refs/heads/master@{#445521}
Committed: https://chromium.googlesource.com/chromium/src/+/aa9685be1655d6381be79883c154c46b22d0b0fb
Patch Set 1 #Patch Set 2 : change to UnspecedLoading #
Messages
Total messages: 24 (16 generated)
The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Migrate Timer to TaskRunnerTimer in InspectorNetworkAgent Migrate Timer to TaskRunnerTimer in InspectorNetworkAgent InspectorNetworkAgent is associated with networking task source. BUG=624694 ========== to ========== Migrate Timer to TaskRunnerTimer in InspectorNetworkAgent Migrate Timer to TaskRunnerTimer in InspectorNetworkAgent InspectorNetworkAgent is associated with networking task source. BUG=624694 ==========
hs1217.lee@samsung.com changed reviewers: + haraken@chromium.org
@haraken PTAL, Thank you
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Inspector is an internal thing, and thus the task should not be a speced one. So I think we should use UnspecedTimer or UnspecedLoading. Given that the task is about XHR, UnspecedLoading would be better.
Description was changed from ========== Migrate Timer to TaskRunnerTimer in InspectorNetworkAgent Migrate Timer to TaskRunnerTimer in InspectorNetworkAgent InspectorNetworkAgent is associated with networking task source. BUG=624694 ========== to ========== Migrate Timer to TaskRunnerTimer in InspectorNetworkAgent Migrate Timer to TaskRunnerTimer in InspectorNetworkAgent Inspector is internal things. so it is not speced. UnspecedLoading was choosed as TaskType. because it is task about XHR. BUG=624694 ==========
The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, no build URL)
On 2017/01/23 00:10:43, haraken wrote: > Inspector is an internal thing, and thus the task should not be a speced one. So > I think we should use UnspecedTimer or UnspecedLoading. Given that the task is > about XHR, UnspecedLoading would be better. i changed to UnspecedLoading from Networking. PTAL, thank you.
LGTM
The CQ bit was checked by hs1217.lee@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by hs1217.lee@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485206170383200,
"parent_rev": "30e0ef53363917a324acf0b89f62f64223d06f3f", "commit_rev":
"aa9685be1655d6381be79883c154c46b22d0b0fb"}
Message was sent while issue was closed.
Description was changed from ========== Migrate Timer to TaskRunnerTimer in InspectorNetworkAgent Migrate Timer to TaskRunnerTimer in InspectorNetworkAgent Inspector is internal things. so it is not speced. UnspecedLoading was choosed as TaskType. because it is task about XHR. BUG=624694 ========== to ========== Migrate Timer to TaskRunnerTimer in InspectorNetworkAgent Migrate Timer to TaskRunnerTimer in InspectorNetworkAgent Inspector is internal things. so it is not speced. UnspecedLoading was choosed as TaskType. because it is task about XHR. BUG=624694 Review-Url: https://codereview.chromium.org/2648083002 Cr-Commit-Position: refs/heads/master@{#445521} Committed: https://chromium.googlesource.com/chromium/src/+/aa9685be1655d6381be79883c154... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/aa9685be1655d6381be79883c154... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
