LogDog: Use live object cache for configs.

LogDog: Use live object cache for configs.

Rather than unmarshalling configurations each time, use a live-object
cache via proccache for configurations.

BUG=chromium:682465
TEST=None

Review-Url: https://codereview.chromium.org/2648033002
Committed: https://github.com/luci/luci-go/commit/d3d6702a41f2ae2d2256d7e541917dbe20eccec8

[dnj, 2017-01-20 23:40:08]

dnj@chromium.org changed reviewers:
+ iannucci@chromium.org

[dnj, 2017-01-20 23:40:09]

PTAL

[iannucci, 2017-01-21 00:27:05]

lgtm

https://codereview.chromium.org/2648033002/diff/20001/logdog/server/service/c...
File logdog/server/service/config/cache.go (right):

https://codereview.chromium.org/2648033002/diff/20001/logdog/server/service/c...
logdog/server/service/config/cache.go:23: // Lifetime is the lifetime of the
cached object.
of each cached object? This can cache more than one object, right?

https://codereview.chromium.org/2648033002/diff/20001/logdog/server/service/c...
logdog/server/service/config/cache.go:61: cset cfgtypes.ConfigSet
this is a `string` underlying type, right?

[dnj, 2017-01-21 01:53:06]

https://codereview.chromium.org/2648033002/diff/20001/logdog/server/service/c...
File logdog/server/service/config/cache.go (right):

https://codereview.chromium.org/2648033002/diff/20001/logdog/server/service/c...
logdog/server/service/config/cache.go:23: // Lifetime is the lifetime of the
cached object.
On 2017/01/21 00:27:05, iannucci wrote:
> of each cached object? This can cache more than one object, right?

Yeah this is just the cache. Really, behind the scenes, it uses proccache, so
this is just passed on to proccache.

https://codereview.chromium.org/2648033002/diff/20001/logdog/server/service/c...
logdog/server/service/config/cache.go:61: cset cfgtypes.ConfigSet
On 2017/01/21 00:27:05, iannucci wrote:
> this is a `string` underlying type, right?

Yep

[dnj, 2017-01-21 01:53:09]

The CQ bit was checked by dnj@chromium.org

[dnj, 2017-01-21 01:53:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
iannucci@chromium.org
Link to the patchset: https://codereview.chromium.org/2648033002/#ps40001
(title: "Renaming, actually use it :/")

[commit-bot: I haz the power, 2017-01-21 01:53:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-21 01:59:29]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484963589917960,
"parent_rev": "95c4ae33d6197d7098ab2b895ccc3a14b1b82602", "commit_rev":
"d3d6702a41f2ae2d2256d7e541917dbe20eccec8"}

[commit-bot: I haz the power, 2017-01-21 01:59:32]

Description was changed from

==========
LogDog: Use live object cache for configs.

Rather than unmarshalling configurations each time, use a live-object
cache via proccache for configurations.

BUG=chromium:682465
TEST=None
==========

to

==========
LogDog: Use live object cache for configs.

Rather than unmarshalling configurations each time, use a live-object
cache via proccache for configurations.

BUG=chromium:682465
TEST=None

Review-Url: https://codereview.chromium.org/2648033002
Committed:
https://github.com/luci/luci-go/commit/d3d6702a41f2ae2d2256d7e541917dbe20eccec8
==========

[commit-bot: I haz the power, 2017-01-21 01:59:33]

Committed patchset #3 (id:40001) as
https://github.com/luci/luci-go/commit/d3d6702a41f2ae2d2256d7e541917dbe20eccec8