Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2648023002: Use TaskRunnerTimer in LinkLoader (Closed)

Created:
3 years, 11 months ago by Charlie Harrison
Modified:
3 years, 11 months ago
Reviewers:
Yoav Weiss
CC:
chromium-reviews, gavinp+prerender_chromium.org, blink-reviews-html_chromium.org, tyoshino+watch_chromium.org, loading-reviews_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, blink-reviews, Nate Chapin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use TaskRunnerTimer in LinkLoader This is a blocker for the per-frame scheduler. BUG=624694 Review-Url: https://codereview.chromium.org/2648023002 Cr-Commit-Position: refs/heads/master@{#445444} Committed: https://chromium.googlesource.com/chromium/src/+/3316a2fb1b3533b08614e59163ceadb6b221fa1f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -7 lines) Patch
M third_party/WebKit/Source/core/html/HTMLLinkElement.h View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLLinkElement.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/LinkLoader.h View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/loader/LinkLoader.cpp View 1 chunk +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/loader/LinkLoaderClient.h View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
Charlie Harrison
Yoav: PTAL?
3 years, 11 months ago (2017-01-20 22:21:09 UTC) #4
Yoav Weiss
On 2017/01/20 22:21:09, Charlie Harrison wrote: > Yoav: PTAL? LGTM
3 years, 11 months ago (2017-01-23 08:55:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2648023002/1
3 years, 11 months ago (2017-01-23 14:21:25 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/368764) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, ...
3 years, 11 months ago (2017-01-23 14:22:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2648023002/1
3 years, 11 months ago (2017-01-23 14:23:01 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/352985)
3 years, 11 months ago (2017-01-23 14:23:49 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2648023002/1
3 years, 11 months ago (2017-01-23 18:52:50 UTC) #17
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 19:54:50 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3316a2fb1b3533b08614e59163ce...

Powered by Google App Engine
This is Rietveld 408576698