Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 2647973002: Add layout test suppression for upcoming Skia DEPS roll (Closed)

Created:
3 years, 11 months ago by robertphillips
Modified:
3 years, 11 months ago
Reviewers:
jcgregorio, f(malita), reed2
CC:
chromium-reviews, blink-reviews, jcgregorio1, hcm1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add layout test suppression for upcoming Skia DEPS roll Not to be landed until Skia is about to start rolling again BUG=683312 Review-Url: https://codereview.chromium.org/2647973002 Cr-Commit-Position: refs/heads/master@{#445272} Committed: https://chromium.googlesource.com/chromium/src/+/0e03a131eaf48ffbd708263f5e86be5b4f0c486f

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix failure type #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
robertphillips
3 years, 11 months ago (2017-01-20 20:01:41 UTC) #3
f(malita)
lgtm https://codereview.chromium.org/2647973002/diff/1/third_party/WebKit/LayoutTests/TestExpectations File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/2647973002/diff/1/third_party/WebKit/LayoutTests/TestExpectations#newcode111 third_party/WebKit/LayoutTests/TestExpectations:111: crbug.com/683312 virtual/gpu/fast/canvas/canvas-pattern-no-repeat-with-transformations.html [ Failure ] nit: [ NeedsManualRebaseline ...
3 years, 11 months ago (2017-01-20 20:05:39 UTC) #4
robertphillips
https://codereview.chromium.org/2647973002/diff/1/third_party/WebKit/LayoutTests/TestExpectations File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/2647973002/diff/1/third_party/WebKit/LayoutTests/TestExpectations#newcode111 third_party/WebKit/LayoutTests/TestExpectations:111: crbug.com/683312 virtual/gpu/fast/canvas/canvas-pattern-no-repeat-with-transformations.html [ Failure ] On 2017/01/20 20:05:39, f(malita) ...
3 years, 11 months ago (2017-01-20 20:09:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2647973002/20001
3 years, 11 months ago (2017-01-21 04:16:57 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-21 05:14:01 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0e03a131eaf48ffbd708263f5e86...

Powered by Google App Engine
This is Rietveld 408576698