Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Unified Diff: ios/web/public/web_client.h

Issue 2647943004: Return unique_ptr from WebClient::CreateWebMainParts() (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/public/web_client.h
diff --git a/ios/web/public/web_client.h b/ios/web/public/web_client.h
index a852a760058eaaa86d52960f3a24185b4aca0fb7..7e59485ae13a0012ba312775d74793d47712aa89 100644
--- a/ios/web/public/web_client.h
+++ b/ios/web/public/web_client.h
@@ -12,6 +12,7 @@
#include "base/strings/string16.h"
#include "base/strings/string_piece.h"
#include "base/task_scheduler/task_scheduler.h"
+#include "ios/web/public/app/web_main_parts.h"
Eugene But (OOO till 7-30) 2017/01/20 22:11:41 There is no need for include. Having predeclaratio
michaeldo 2017/01/23 17:30:54 Done.
#include "ui/base/layout.h"
#include "url/url_util.h"
@@ -34,7 +35,6 @@ namespace web {
class BrowserState;
class BrowserURLRewriter;
class WebClient;
-class WebMainParts;
class WebState;
// Setter and getter for the client. The client should be set early, before any
@@ -50,7 +50,7 @@ class WebClient {
// Allows the embedder to set a custom WebMainParts implementation for the
// browser startup code.
- virtual WebMainParts* CreateWebMainParts();
+ virtual std::unique_ptr<WebMainParts> CreateWebMainParts();
// Gives the embedder a chance to perform tasks before a web view is created.
virtual void PreWebViewCreation() const {}

Powered by Google App Engine
This is Rietveld 408576698