Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Unified Diff: ios/chrome/browser/web/chrome_web_client.mm

Issue 2647943004: Return unique_ptr from WebClient::CreateWebMainParts() (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/web/chrome_web_client.mm
diff --git a/ios/chrome/browser/web/chrome_web_client.mm b/ios/chrome/browser/web/chrome_web_client.mm
index ccf042f332e166d5afd3775ff80fd8170d17cb16..b226eb8067be25fb5f3531aca0967e6581fc0855 100644
--- a/ios/chrome/browser/web/chrome_web_client.mm
+++ b/ios/chrome/browser/web/chrome_web_client.mm
@@ -59,8 +59,9 @@ ChromeWebClient::ChromeWebClient() {}
ChromeWebClient::~ChromeWebClient() {}
-web::WebMainParts* ChromeWebClient::CreateWebMainParts() {
- return new IOSChromeMainParts(*base::CommandLine::ForCurrentProcess());
+std::unique_ptr<web::WebMainParts> ChromeWebClient::CreateWebMainParts() {
+ return base::MakeUnique<IOSChromeMainParts>(
Eugene But (OOO till 7-30) 2017/01/20 22:11:41 Please add include of ptr_util everywhere where ba
michaeldo 2017/01/23 17:30:54 Done.
+ *base::CommandLine::ForCurrentProcess());
}
void ChromeWebClient::PreWebViewCreation() const {

Powered by Google App Engine
This is Rietveld 408576698