Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2647943004: Return unique_ptr from WebClient::CreateWebMainParts() (Closed)

Created:
3 years, 11 months ago by michaeldo
Modified:
3 years, 6 months ago
CC:
chromium-reviews, marq+watch_chromium.org, Eugene But (OOO till 7-30), pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Return unique_ptr from WebClient::CreateWebMainParts() This issue was observed in the following CL: https://codereview.chromium.org/2643773005/diff/1/ios/web_view/internal/criwv_web_client.mm BUG=683207

Patch Set 1 #

Total comments: 8

Patch Set 2 : Respond to comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -11 lines) Patch
M ios/chrome/browser/web/chrome_web_client.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M ios/chrome/browser/web/chrome_web_client.mm View 1 2 chunks +4 lines, -2 lines 0 comments Download
M ios/web/app/web_main_loop.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/public/web_client.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M ios/web/public/web_client.mm View 1 2 chunks +3 lines, -1 line 0 comments Download
M ios/web/shell/shell_web_client.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ios/web/shell/shell_web_client.mm View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
michaeldo
3 years, 11 months ago (2017-01-20 22:01:44 UTC) #3
Eugene But (OOO till 7-30)
lgtm https://codereview.chromium.org/2647943004/diff/1/ios/chrome/browser/web/chrome_web_client.h File ios/chrome/browser/web/chrome_web_client.h (right): https://codereview.chromium.org/2647943004/diff/1/ios/chrome/browser/web/chrome_web_client.h#newcode18 ios/chrome/browser/web/chrome_web_client.h:18: std::unique_ptr<web::WebMainParts> CreateWebMainParts() override; Please include <memory> everywhere where ...
3 years, 11 months ago (2017-01-20 22:11:42 UTC) #4
michaeldo
https://codereview.chromium.org/2647943004/diff/1/ios/chrome/browser/web/chrome_web_client.h File ios/chrome/browser/web/chrome_web_client.h (right): https://codereview.chromium.org/2647943004/diff/1/ios/chrome/browser/web/chrome_web_client.h#newcode18 ios/chrome/browser/web/chrome_web_client.h:18: std::unique_ptr<web::WebMainParts> CreateWebMainParts() override; On 2017/01/20 22:11:41, Eugene But wrote: ...
3 years, 11 months ago (2017-01-23 17:30:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2647943004/20001
3 years, 11 months ago (2017-01-23 17:35:02 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 17:41:14 UTC) #10
Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

Powered by Google App Engine
This is Rietveld 408576698