Return unique_ptr from WebClient::CreateWebMainParts()

Return unique_ptr from WebClient::CreateWebMainParts()

This issue was observed in the following CL:
https://codereview.chromium.org/2643773005/diff/1/ios/web_view/internal/criwv_web_client.mm

BUG=683207

[michaeldo, 2017-01-20 22:01:31]

Description was changed from

==========
Return unique_ptr from WebClient::CreateWebMainParts()

BUG=683207
==========

to

==========
Return unique_ptr from WebClient::CreateWebMainParts()

This issue was observed in the following CL:
https://codereview.chromium.org/2643773005/diff/1/ios/web_view/internal/criwv...

BUG=683207
==========

[michaeldo, 2017-01-20 22:01:43]

michaeldo@chromium.org changed reviewers:
+ eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2017-01-20 22:11:42]

lgtm

https://codereview.chromium.org/2647943004/diff/1/ios/chrome/browser/web/chro...
File ios/chrome/browser/web/chrome_web_client.h (right):

https://codereview.chromium.org/2647943004/diff/1/ios/chrome/browser/web/chro...
ios/chrome/browser/web/chrome_web_client.h:18:
std::unique_ptr<web::WebMainParts> CreateWebMainParts() override;
Please include <memory> everywhere where std::unique_ptr is used.

https://codereview.chromium.org/2647943004/diff/1/ios/chrome/browser/web/chro...
File ios/chrome/browser/web/chrome_web_client.mm (right):

https://codereview.chromium.org/2647943004/diff/1/ios/chrome/browser/web/chro...
ios/chrome/browser/web/chrome_web_client.mm:63: return
base::MakeUnique<IOSChromeMainParts>(
Please add include of ptr_util everywhere where base::MakeUnique is used.

https://codereview.chromium.org/2647943004/diff/1/ios/web/public/web_client.h
File ios/web/public/web_client.h (right):

https://codereview.chromium.org/2647943004/diff/1/ios/web/public/web_client.h...
ios/web/public/web_client.h:15: #include "ios/web/public/app/web_main_parts.h"
There is no need for include. Having predeclaration is fine.

https://codereview.chromium.org/2647943004/diff/1/ios/web/shell/shell_web_cli...
File ios/web/shell/shell_web_client.h (right):

https://codereview.chromium.org/2647943004/diff/1/ios/web/shell/shell_web_cli...
ios/web/shell/shell_web_client.h:38: ShellWebMainParts* web_main_parts_;  //
weak
nit: "weak" has very specific meaning on iOS and this is not a weak pointer.

[michaeldo, 2017-01-23 17:30:54]

https://codereview.chromium.org/2647943004/diff/1/ios/chrome/browser/web/chro...
File ios/chrome/browser/web/chrome_web_client.h (right):

https://codereview.chromium.org/2647943004/diff/1/ios/chrome/browser/web/chro...
ios/chrome/browser/web/chrome_web_client.h:18:
std::unique_ptr<web::WebMainParts> CreateWebMainParts() override;
On 2017/01/20 22:11:41, Eugene But wrote:
> Please include <memory> everywhere where std::unique_ptr is used.

Done.

https://codereview.chromium.org/2647943004/diff/1/ios/chrome/browser/web/chro...
File ios/chrome/browser/web/chrome_web_client.mm (right):

https://codereview.chromium.org/2647943004/diff/1/ios/chrome/browser/web/chro...
ios/chrome/browser/web/chrome_web_client.mm:63: return
base::MakeUnique<IOSChromeMainParts>(
On 2017/01/20 22:11:41, Eugene But wrote:
> Please add include of ptr_util everywhere where base::MakeUnique is used.

Done.

https://codereview.chromium.org/2647943004/diff/1/ios/web/public/web_client.h
File ios/web/public/web_client.h (right):

https://codereview.chromium.org/2647943004/diff/1/ios/web/public/web_client.h...
ios/web/public/web_client.h:15: #include "ios/web/public/app/web_main_parts.h"
On 2017/01/20 22:11:41, Eugene But wrote:
> There is no need for include. Having predeclaration is fine.

Done.

https://codereview.chromium.org/2647943004/diff/1/ios/web/shell/shell_web_cli...
File ios/web/shell/shell_web_client.h (right):

https://codereview.chromium.org/2647943004/diff/1/ios/web/shell/shell_web_cli...
ios/web/shell/shell_web_client.h:38: ShellWebMainParts* web_main_parts_;  //
weak
On 2017/01/20 22:11:41, Eugene But wrote:
> nit: "weak" has very specific meaning on iOS and this is not a weak pointer.

Done.

[michaeldo, 2017-01-23 17:34:32]

The CQ bit was checked by michaeldo@chromium.org

[michaeldo, 2017-01-23 17:34:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2647943004/#ps20001
(title: "Respond to comments.")

[commit-bot: I haz the power, 2017-01-23 17:35:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 17:41:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 17:41:14]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)