Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Side by Side Diff: ios/web/public/web_client.mm

Issue 2647943004: Return unique_ptr from WebClient::CreateWebMainParts() (Closed)
Patch Set: Respond to comments. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ios/web/public/web_client.h ('k') | ios/web/shell/shell_web_client.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "ios/web/public/web_client.h" 5 #import "ios/web/public/web_client.h"
6 6
7 #import <Foundation/Foundation.h> 7 #import <Foundation/Foundation.h>
8 8
9 #include "ios/web/public/app/web_main_parts.h"
10
9 #if !defined(__has_feature) || !__has_feature(objc_arc) 11 #if !defined(__has_feature) || !__has_feature(objc_arc)
10 #error "This file requires ARC support." 12 #error "This file requires ARC support."
11 #endif 13 #endif
12 14
13 namespace web { 15 namespace web {
14 16
15 static WebClient* g_client; 17 static WebClient* g_client;
16 18
17 void SetWebClient(WebClient* client) { 19 void SetWebClient(WebClient* client) {
18 g_client = client; 20 g_client = client;
19 } 21 }
20 22
21 WebClient* GetWebClient() { 23 WebClient* GetWebClient() {
22 return g_client; 24 return g_client;
23 } 25 }
24 26
25 WebClient::WebClient() { 27 WebClient::WebClient() {
26 } 28 }
27 29
28 WebClient::~WebClient() { 30 WebClient::~WebClient() {
29 } 31 }
30 32
31 WebMainParts* WebClient::CreateWebMainParts() { 33 std::unique_ptr<WebMainParts> WebClient::CreateWebMainParts() {
32 return nullptr; 34 return nullptr;
33 } 35 }
34 36
35 std::string WebClient::GetAcceptLangs(BrowserState* state) const { 37 std::string WebClient::GetAcceptLangs(BrowserState* state) const {
36 return std::string(); 38 return std::string();
37 } 39 }
38 40
39 std::string WebClient::GetApplicationLocale() const { 41 std::string WebClient::GetApplicationLocale() const {
40 return "en-US"; 42 return "en-US";
41 } 43 }
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 WebState* web_state, 84 WebState* web_state,
83 int cert_error, 85 int cert_error,
84 const net::SSLInfo& ssl_info, 86 const net::SSLInfo& ssl_info,
85 const GURL& request_url, 87 const GURL& request_url,
86 bool overridable, 88 bool overridable,
87 const base::Callback<void(bool)>& callback) { 89 const base::Callback<void(bool)>& callback) {
88 callback.Run(false); 90 callback.Run(false);
89 } 91 }
90 92
91 } // namespace web 93 } // namespace web
OLDNEW
« no previous file with comments | « ios/web/public/web_client.h ('k') | ios/web/shell/shell_web_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698