Implements RTP header dumping.

chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc

Index: chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc
diff --git a/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc b/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc
index 9d02674b65a561a2a92fde4c19d7f6d97cb503c2..9544109251ca3e8278dae665ed6ec0784cfc8e6f 100644
--- a/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc
+++ b/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc
@@ -298,6 +298,8 @@ bool WebrtcLoggingPrivateStartRtpDumpFunction::RunAsync() {
                                      params->outgoing,
                                      callback));
 
+  host->StartRtpDump(params->incoming, params->outgoing);

[Henrik Grunell, 2014/05/14 12:14:12]

Can this fail? Does it need to finish before we send the completion callback to
the extension? (I saw in RenderProcessHostImpl that it posts  a task.) For
example, if whatever is done in that task hasn't finished when StopRtpDump is
called here, is that OK?

Maybe RPH should responsible for calling LHH and we will only need RPH from
here? Not sure if that's better. Either way, I think it should be documented how
this works.

[jiayl, 2014/05/14 16:07:58]

It cannot fail and we do not need to block the callback.

LHH (in chrome) is not a known type to RPH (in content). We'll need a new
content public interface to make RPH directly call LHH. I'd prefer the current
way.

I'll add comments to explain.

[Henrik Grunell, 2014/05/15 14:36:34]

OK.

+
   return true;
 }
 
@@ -339,6 +341,8 @@ bool WebrtcLoggingPrivateStopRtpDumpFunction::RunAsync() {
                                      params->outgoing,
                                      callback));
 
+  host->StopRtpDump(params->incoming, params->outgoing);
+
   return true;
 }