Implements RTP header dumping.

chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.h"
 
 #include "base/logging.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 280 matching lines @@
       &WebrtcLoggingPrivateStartRtpDumpFunction::StartRtpDumpCallback, this);
 
   BrowserThread::PostTask(BrowserThread::IO,
                           FROM_HERE,
                           base::Bind(&WebRtcLoggingHandlerHost::StartRtpDump,
                                      webrtc_logging_handler_host,
                                      params->incoming,
                                      params->outgoing,
                                      callback));
 
+  host->StartRtpDump(params->incoming, params->outgoing);

[Henrik Grunell, 2014/05/14 12:14:12]

Can this fail? Does it need to finish before we send the completion callback to
the extension? (I saw in RenderProcessHostImpl that it posts  a task.) For
example, if whatever is done in that task hasn't finished when StopRtpDump is
called here, is that OK?

Maybe RPH should responsible for calling LHH and we will only need RPH from
here? Not sure if that's better. Either way, I think it should be documented how
this works.

[jiayl, 2014/05/14 16:07:58]

It cannot fail and we do not need to block the callback.

LHH (in chrome) is not a known type to RPH (in content). We'll need a new
content public interface to make RPH directly call LHH. I'd prefer the current
way.

I'll add comments to explain.

[Henrik Grunell, 2014/05/15 14:36:34]

OK.

+
   return true;
 }
 
 void WebrtcLoggingPrivateStartRtpDumpFunction::StartRtpDumpCallback(
     bool success,
     const std::string& error_message) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
   if (!success)
     SetError(error_message);
   SendResponse(success);
@@ skipping 21 matching lines @@
       &WebrtcLoggingPrivateStopRtpDumpFunction::StopRtpDumpCallback, this);
 
   BrowserThread::PostTask(BrowserThread::IO,
                           FROM_HERE,
                           base::Bind(&WebRtcLoggingHandlerHost::StopRtpDump,
                                      webrtc_logging_handler_host,
                                      params->incoming,
                                      params->outgoing,
                                      callback));
 
+  host->StopRtpDump(params->incoming, params->outgoing);
+
   return true;
 }
 
 void WebrtcLoggingPrivateStopRtpDumpFunction::StopRtpDumpCallback(
     bool success,
     const std::string& error_message) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
   if (!success)
     SetError(error_message);
   SendResponse(success);
 }
 
 }  // namespace extensions