Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2889)

Unified Diff: chrome/common/extensions/docs/server2/local_file_system.py

Issue 264793013: Fixing Extensions Integration Test LocalFileSystem path issues under Windows (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/docs/server2/local_file_system.py
diff --git a/chrome/common/extensions/docs/server2/local_file_system.py b/chrome/common/extensions/docs/server2/local_file_system.py
index 8655cfe8eba5763c9c682fe59482106689d2e75b..2cd880bd3bb5f0fd91ffd83131c67604f2bc2f39 100644
--- a/chrome/common/extensions/docs/server2/local_file_system.py
+++ b/chrome/common/extensions/docs/server2/local_file_system.py
@@ -69,6 +69,7 @@ class LocalFileSystem(FileSystem):
filesystem.
'''
def __init__(self, base_path):
+ base_path = base_path.replace('\\', '/') # Convert to POSIX path.
not at google - send to devlin 2014/05/02 19:23:41 os.path would be more idiomatic. comment not very
huangs 2014/05/02 21:07:01 os.path.split() is not the inverse of os.path.join
not at google - send to devlin 2014/05/02 21:07:41 bleh, I meant os.sep not os.path.
AssertIsDirectory(base_path)
self._base_path = _ConvertToFilepath(base_path)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698