Fixing Extensions Integration Test LocalFileSystem path issues under Windows

chrome/common/extensions/docs/server2/local_file_system.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import os
 import sys
 
 from docs_server_utils import StringIdentity
 from file_system import FileSystem, FileNotFoundError, StatInfo
 from future import Future
@@ skipping 51 matching lines @@
     return StatInfo(version, child_versions)
   except OSError as e:
     raise FileNotFoundError('os.stat failed for %s: %s' % (path, e))
 
 
 class LocalFileSystem(FileSystem):
   '''FileSystem implementation which fetches resources from the local
   filesystem.
   '''
   def __init__(self, base_path):
+    base_path = base_path.replace('\\', '/')  # Convert to POSIX path.

[not at google - send to devlin, 2014/05/02 19:23:41]

os.path would be more idiomatic. comment not very useful in its current form,
but if you mentioned that it was so that path validity checks pass... that would
be usefu.

[huangs, 2014/05/02 21:07:01]

os.path.split() is not the inverse of os.path.join() (only extracts path &
filename, rather than extract components).

I tried posixpath, and that didn't convert '\\' to '/'.

I found the code using .replace(os.sep, '/') elsewhere in this directory, so
using that.

[not at google - send to devlin, 2014/05/02 21:07:41]

bleh, I meant os.sep not os.path.

     AssertIsDirectory(base_path)
     self._base_path = _ConvertToFilepath(base_path)
 
   @staticmethod
   def Create(*path):
     return LocalFileSystem(ChromiumPath(*path))
 
   def Read(self, paths, skip_not_found=False):
     def resolve():
       result = {}
@@ skipping 15 matching lines @@
     AssertIsValid(path)
     full_path = os.path.join(self._base_path,
                              _ConvertToFilepath(path).lstrip(os.sep))
     return _CreateStatInfo(full_path)
 
   def GetIdentity(self):
     return '@'.join((self.__class__.__name__, StringIdentity(self._base_path)))
 
   def __repr__(self):
     return 'LocalFileSystem(%s)' % self._base_path