Fixing Extensions Integration Test LocalFileSystem path issues under Windows

Fixing Extensions Integration Test LocalFileSystem path issues under Windows

This fixes \src\chrome\common\extensions\dos\server2\integration_test.py
failure under Windows.  Here, path_utils.py requires path with separator '/', but it's given separator '\\' in Windows and fails.

BUG=369510
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267952

[huangs, 2014-05-02 18:33:25]

PTAL.

[not at google - send to devlin, 2014-05-02 19:23:40]

lgtm

https://codereview.chromium.org/264793013/diff/1/chrome/common/extensions/doc...
File chrome/common/extensions/docs/server2/local_file_system.py (right):

https://codereview.chromium.org/264793013/diff/1/chrome/common/extensions/doc...
chrome/common/extensions/docs/server2/local_file_system.py:72: base_path =
base_path.replace('\\', '/')  # Convert to POSIX path.
os.path would be more idiomatic. comment not very useful in its current form,
but if you mentioned that it was so that path validity checks pass... that would
be usefu.

[huangs, 2014-05-02 21:07:00]

https://codereview.chromium.org/264793013/diff/1/chrome/common/extensions/doc...
File chrome/common/extensions/docs/server2/local_file_system.py (right):

https://codereview.chromium.org/264793013/diff/1/chrome/common/extensions/doc...
chrome/common/extensions/docs/server2/local_file_system.py:72: base_path =
base_path.replace('\\', '/')  # Convert to POSIX path.
os.path.split() is not the inverse of os.path.join() (only extracts path &
filename, rather than extract components).

I tried posixpath, and that didn't convert '\\' to '/'.

I found the code using .replace(os.sep, '/') elsewhere in this directory, so
using that.

[not at google - send to devlin, 2014-05-02 21:07:41]

https://codereview.chromium.org/264793013/diff/1/chrome/common/extensions/doc...
File chrome/common/extensions/docs/server2/local_file_system.py (right):

https://codereview.chromium.org/264793013/diff/1/chrome/common/extensions/doc...
chrome/common/extensions/docs/server2/local_file_system.py:72: base_path =
base_path.replace('\\', '/')  # Convert to POSIX path.
On 2014/05/02 21:07:01, huangs1 wrote:
> os.path.split() is not the inverse of os.path.join() (only extracts path &
> filename, rather than extract components).
> 
> I tried posixpath, and that didn't convert '\\' to '/'.
> 
> I found the code using .replace(os.sep, '/') elsewhere in this directory, so
> using that.

bleh, I meant os.sep not os.path.

[huangs, 2014-05-02 21:10:23]

The CQ bit was checked by huangs@chromium.org

[commit-bot: I haz the power, 2014-05-02 21:10:53]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/huangs@chromium.org/264793013/20001

[commit-bot: I haz the power, 2014-05-02 21:27:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-02 21:27:40]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium
  linux_chromium_rel on tryserver.chromium

[not at google - send to devlin, 2014-05-02 21:52:43]

use NOTRY=true

[huangs, 2014-05-02 22:52:23]

The CQ bit was checked by huangs@chromium.org

[commit-bot: I haz the power, 2014-05-02 22:53:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/huangs@chromium.org/264793013/30001

[commit-bot: I haz the power, 2014-05-02 23:05:13]

Change committed as 267952