Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1261)

Issue 2647873002: Revert of [heap] Provide ObjectMarking with marking transitions (Closed)

Created:
3 years, 11 months ago by Benedikt Meurer
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Provide ObjectMarking with marking transitions (patchset #5 id:80001 of https://codereview.chromium.org/2644523002/ ) Reason for revert: Breaks the tree: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/8349/steps/Mjsunit/logs/compiled-module-seria.. Original issue's description: > [heap] Provide ObjectMarking with marking transitions > > BUG=chromium:651354 > > Review-Url: https://codereview.chromium.org/2644523002 > Cr-Commit-Position: refs/heads/master@{#42531} > Committed: https://chromium.googlesource.com/v8/v8/+/cbb8929e97ee475dab4f704a71637e76342e903a TBR=hpayer@chromium.org,mlippautz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:651354 Review-Url: https://codereview.chromium.org/2647873002 Cr-Commit-Position: refs/heads/master@{#42533} Committed: https://chromium.googlesource.com/v8/v8/+/3258bef0adc66fa2722ccea364fd3655e4a9e5d6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -191 lines) Patch
M src/heap/array-buffer-tracker.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/heap/heap.cc View 8 chunks +9 lines, -11 lines 0 comments Download
M src/heap/incremental-marking.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/incremental-marking.cc View 14 chunks +59 lines, -36 lines 0 comments Download
M src/heap/mark-compact.h View 2 chunks +1 line, -71 lines 0 comments Download
M src/heap/mark-compact.cc View 34 chunks +69 lines, -45 lines 0 comments Download
M src/heap/mark-compact-inl.h View 2 chunks +22 lines, -12 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/heap/scavenger.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M src/heap/spaces.cc View 5 chunks +9 lines, -8 lines 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Benedikt Meurer
Created Revert of [heap] Provide ObjectMarking with marking transitions
3 years, 11 months ago (2017-01-20 08:29:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2647873002/1
3 years, 11 months ago (2017-01-20 08:30:03 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 08:30:14 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/3258bef0adc66fa2722ccea364fd3655e4a...

Powered by Google App Engine
This is Rietveld 408576698