Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2647833003: Adds AppListDelegate to AppList that is notified on visibility changes (Closed)

Created:
3 years, 11 months ago by sky
Modified:
3 years, 11 months ago
Reviewers:
Tom Sepez, xiyuan
CC:
chromium-reviews, sadrul, Matt Giuca, viettrungluu+watch_chromium.org, tfarina, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review), qsr+mojo_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds AppListDelegate to AppList that is notified on visibility changes For mash chrome shows the app-list. Mash needs to inform the AppListButton when the visibility changes otherwise the ink drop animations checks. To address this ash installs an AppListDelegate that is notified on visibility changes so that it can update the button. BUG=681168 TEST=none R=xiyuan@chromium.org Review-Url: https://codereview.chromium.org/2647833003 Cr-Commit-Position: refs/heads/master@{#445111} Committed: https://chromium.googlesource.com/chromium/src/+/15ef0aa9060364567a6cf2abd20f6d419619cc83

Patch Set 1 #

Patch Set 2 : include #

Patch Set 3 : fix #

Total comments: 2

Patch Set 4 : move #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -8 lines) Patch
M ash/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A ash/app_list/app_list_delegate_impl.h View 1 chunk +28 lines, -0 lines 0 comments Download
A ash/app_list/app_list_delegate_impl.cc View 1 chunk +38 lines, -0 lines 0 comments Download
M ash/app_list/app_list_presenter_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_view_unittest.cc View 1 2 4 chunks +12 lines, -2 lines 0 comments Download
M ash/shell.h View 2 chunks +3 lines, -0 lines 0 comments Download
M ash/shell.cc View 3 chunks +7 lines, -0 lines 0 comments Download
M ui/app_list/presenter/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/app_list/presenter/app_list.h View 1 2 3 3 chunks +7 lines, -1 line 0 comments Download
M ui/app_list/presenter/app_list.cc View 1 2 2 chunks +8 lines, -1 line 0 comments Download
A ui/app_list/presenter/app_list_delegate.h View 1 chunk +26 lines, -0 lines 0 comments Download
M ui/app_list/presenter/app_list_presenter.mojom View 1 chunk +3 lines, -1 line 0 comments Download
M ui/app_list/presenter/app_list_presenter_impl.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M ui/app_list/presenter/app_list_presenter_impl.cc View 4 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
sky
tsepez: mojom xiyuan: the rest
3 years, 11 months ago (2017-01-20 04:07:48 UTC) #3
xiyuan
lgtm https://codereview.chromium.org/2647833003/diff/40001/ui/app_list/presenter/app_list.h File ui/app_list/presenter/app_list.h (right): https://codereview.chromium.org/2647833003/diff/40001/ui/app_list/presenter/app_list.h#newcode22 ui/app_list/presenter/app_list.h:22: void set_delegate(AppListDelegate* delegate) { delegate_ = delegate; } ...
3 years, 11 months ago (2017-01-20 17:20:49 UTC) #10
Tom Sepez
lgtm
3 years, 11 months ago (2017-01-20 17:41:39 UTC) #11
sky
https://codereview.chromium.org/2647833003/diff/40001/ui/app_list/presenter/app_list.h File ui/app_list/presenter/app_list.h (right): https://codereview.chromium.org/2647833003/diff/40001/ui/app_list/presenter/app_list.h#newcode22 ui/app_list/presenter/app_list.h:22: void set_delegate(AppListDelegate* delegate) { delegate_ = delegate; } On ...
3 years, 11 months ago (2017-01-20 17:45:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2647833003/60001
3 years, 11 months ago (2017-01-20 17:46:12 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 18:56:35 UTC) #18
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/15ef0aa9060364567a6cf2abd20f...

Powered by Google App Engine
This is Rietveld 408576698