Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: pkg/analyzer/test/src/summary/resynthesize_ast_test.dart

Issue 2647833002: fix #28008, fix #28009 implement FutureOr<T> (Closed)
Patch Set: add test Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/test/src/summary/resynthesize_ast_test.dart
diff --git a/pkg/analyzer/test/src/summary/resynthesize_ast_test.dart b/pkg/analyzer/test/src/summary/resynthesize_ast_test.dart
index aa9cde3d41c5cf0c6cc413d6a90c8a423eb4d0ac..d50c7fee03c3155ea626d6b716905f28fe900238 100644
--- a/pkg/analyzer/test/src/summary/resynthesize_ast_test.dart
+++ b/pkg/analyzer/test/src/summary/resynthesize_ast_test.dart
@@ -701,6 +701,13 @@ var v = new C().m(1, b: 'bbb', c: 2.0);
.test_unsafeBlockClosureInference_methodCall_implicitTypeParam_comment();
}
+ @override
+ @failingTest
+ void test_voidReturnTypeSubtypesDynamic() =>
Paul Berry 2017/01/24 17:45:13 I'm guessing this override is no longer be necessa
Jennifer Messerly 2017/01/25 00:33:35 can confirm. thank you very much! :)
+ // TODO(jmesserly): figure out if it's okay to infer `void` or if we
+ // should infer `dynamic` as the summary code does.
+ super.test_voidReturnTypeSubtypesDynamic();
+
LibraryElementImpl _checkSource(
SummaryResynthesizer resynthesizer, Source source) {
LibraryElementImpl resynthesized =

Powered by Google App Engine
This is Rietveld 408576698