Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Side by Side Diff: pkg/analyzer/test/src/summary/resynthesize_ast_test.dart

Issue 2647833002: fix #28008, fix #28009 implement FutureOr<T> (Closed)
Patch Set: add test Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library analyzer.test.src.summary.resynthesize_ast_test; 5 library analyzer.test.src.summary.resynthesize_ast_test;
6 6
7 import 'package:analyzer/dart/ast/ast.dart'; 7 import 'package:analyzer/dart/ast/ast.dart';
8 import 'package:analyzer/dart/element/element.dart'; 8 import 'package:analyzer/dart/element/element.dart';
9 import 'package:analyzer/error/error.dart'; 9 import 'package:analyzer/error/error.dart';
10 import 'package:analyzer/src/dart/element/element.dart'; 10 import 'package:analyzer/src/dart/element/element.dart';
(...skipping 683 matching lines...) Expand 10 before | Expand all | Expand 10 after
694 super.test_unsafeBlockClosureInference_methodCall_implicitTypeParam(); 694 super.test_unsafeBlockClosureInference_methodCall_implicitTypeParam();
695 } 695 }
696 696
697 @override 697 @override
698 @failingTest 698 @failingTest
699 void test_unsafeBlockClosureInference_methodCall_implicitTypeParam_comment() { 699 void test_unsafeBlockClosureInference_methodCall_implicitTypeParam_comment() {
700 super 700 super
701 .test_unsafeBlockClosureInference_methodCall_implicitTypeParam_comment() ; 701 .test_unsafeBlockClosureInference_methodCall_implicitTypeParam_comment() ;
702 } 702 }
703 703
704 @override
705 @failingTest
706 void test_voidReturnTypeSubtypesDynamic() =>
Paul Berry 2017/01/24 17:45:13 I'm guessing this override is no longer be necessa
Jennifer Messerly 2017/01/25 00:33:35 can confirm. thank you very much! :)
707 // TODO(jmesserly): figure out if it's okay to infer `void` or if we
708 // should infer `dynamic` as the summary code does.
709 super.test_voidReturnTypeSubtypesDynamic();
710
704 LibraryElementImpl _checkSource( 711 LibraryElementImpl _checkSource(
705 SummaryResynthesizer resynthesizer, Source source) { 712 SummaryResynthesizer resynthesizer, Source source) {
706 LibraryElementImpl resynthesized = 713 LibraryElementImpl resynthesized =
707 resynthesizer.getLibraryElement(source.uri.toString()); 714 resynthesizer.getLibraryElement(source.uri.toString());
708 LibraryElementImpl original = context.computeLibraryElement(source); 715 LibraryElementImpl original = context.computeLibraryElement(source);
709 checkLibraryElements(original, resynthesized); 716 checkLibraryElements(original, resynthesized);
710 return resynthesized; 717 return resynthesized;
711 } 718 }
712 } 719 }
713 720
(...skipping 229 matching lines...) Expand 10 before | Expand all | Expand 10 after
943 } 950 }
944 951
945 @override 952 @override
946 DartSdk createDartSdk() => AbstractContextTest.SHARED_MOCK_SDK; 953 DartSdk createDartSdk() => AbstractContextTest.SHARED_MOCK_SDK;
947 954
948 @override 955 @override
949 TestSummaryResynthesizer encodeDecodeLibrarySource(Source source) { 956 TestSummaryResynthesizer encodeDecodeLibrarySource(Source source) {
950 return _encodeLibrary(source); 957 return _encodeLibrary(source);
951 } 958 }
952 } 959 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698