Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js

Issue 2647803002: [Devtools] Fixed network to sort items as they are received. (Closed)
Patch Set: changes Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
index 5625bfe5eaa20e13816b68afd06fc289196ed931..b3140706dd7be591e4d296571194a161f1a16b7d 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
@@ -307,7 +307,7 @@ Network.NetworkWaterfallColumn = class extends UI.VBox {
for (var i = firstRequestIndex; i < lastRequestIndex; i++) {
var rowOffset = this._rowHeight * i;
var node = nodes[i];
- this._decorateRow(context, node, i, rowOffset - this._scrollTop);
+ this._decorateRow(context, node, rowOffset - this._scrollTop);
var drawNodes = [];
if (node.hasChildren() && !node.expanded)
drawNodes = /** @type {!Array<!Network.NetworkNode>} */ (node.flatChildren());
@@ -596,12 +596,11 @@ Network.NetworkWaterfallColumn = class extends UI.VBox {
/**
* @param {!CanvasRenderingContext2D} context
* @param {!Network.NetworkNode} node
- * @param {number} rowNumber
* @param {number} y
*/
- _decorateRow(context, node, rowNumber, y) {
- var isOddRow = rowNumber % 2 === 1;
- if (isOddRow && !node.hovered() && !node.isNavigationRequest() && !node.isOnInitiatorPath() &&
+ _decorateRow(context, node, y) {
+ var isStriped = node.isStriped();
+ if (!isStriped && !node.hovered() && !node.isNavigationRequest() && !node.isOnInitiatorPath() &&
!node.isOnInitiatedPath())
return;
@@ -628,7 +627,7 @@ Network.NetworkWaterfallColumn = class extends UI.VBox {
return this._initiatedColor;
if (node.isNavigationRequest())
return this._rowNavigationRequestColor;
- if (rowNumber % 2 === 1)
+ if (!isStriped)
return 'transparent';
return this._rowStripeColor;
}
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698