Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

Issue 2647803002: [Devtools] Fixed network to sort items as they are received. (Closed)
Patch Set: changes Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
index 7b204cf65f7bb0992066938b3ca77e75fcd641bb..7dc4d44a27b2aa373a0413b21a8b67c3accd6b10 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
@@ -191,6 +191,7 @@ Network.NetworkLogViewColumns = class {
this._activeScroller.scrollTop, this._eventDividersShown ? this._eventDividers : undefined);
return;
}
+ this._syncScrollers();
var nodes = this._networkLogView.flatNodesList();
this._waterfallColumn.update(this._activeScroller.scrollTop, this._eventDividers, nodes);
}
@@ -224,10 +225,6 @@ Network.NetworkLogViewColumns = class {
this._waterfallColumn.setCalculator(x);
}
- dataChanged() {
- this._waterfallRequestsAreStale = true;
- }
-
scheduleRefresh() {
this._waterfallColumn.scheduleDraw();
}
@@ -265,6 +262,7 @@ Network.NetworkLogViewColumns = class {
_sortHandler() {
var columnId = this._dataGrid.sortColumnId();
this._networkLogView.removeAllNodeHighlights();
+ this._waterfallRequestsAreStale = true;
if (columnId === 'waterfall') {
this._waterfallColumnSortIcon.classList.remove('sort-ascending', 'sort-descending');
@@ -273,7 +271,6 @@ Network.NetworkLogViewColumns = class {
else
this._waterfallColumnSortIcon.classList.add('sort-descending');
- this._waterfallRequestsAreStale = true;
var sortFunction = Network.NetworkRequestNode.RequestPropertyComparator.bind(null, this._activeWaterfallSortId);
this._dataGrid.sortNodes(sortFunction, !this._dataGrid.isSortOrderAscending());
this._networkLogView.dataGridSorted();

Powered by Google App Engine
This is Rietveld 408576698