|
|
Revert "Reintroducing MallocHooks changes with fix for infinite loop in MallocHooks on Platform::Exit."
This reverts commit 7bf5d870174fc2f18126bdf5719ebb6209a2ab1d.
The lock introduced by this change in MallocHooksState is held across
a fork(), which causes deadlock in the child when execvpe() fails and
tries to acquire the lock when freeing memory.
Committed: https://github.com/dart-lang/sdk/commit/7730809f360a00d9683057ffcfb9651453e7c1f4
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+46 lines, -510 lines) |
Patch |
 |
M |
runtime/BUILD.gn
|
View
|
|
2 chunks |
+0 lines, -8 lines |
0 comments
|
Download
|
|
M |
runtime/bin/BUILD.gn
|
View
|
|
2 chunks |
+1 line, -4 lines |
0 comments
|
Download
|
|
M |
runtime/bin/bin.gypi
|
View
|
|
2 chunks |
+6 lines, -0 lines |
0 comments
|
Download
|
|
M |
runtime/bin/gen_snapshot.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
runtime/vm/dart.cc
|
View
|
|
3 chunks |
+1 line, -3 lines |
0 comments
|
Download
|
|
M |
runtime/vm/hash_map.h
|
View
|
|
2 chunks |
+0 lines, -63 lines |
0 comments
|
Download
|
|
M |
runtime/vm/hash_map_test.cc
|
View
|
|
2 chunks |
+0 lines, -61 lines |
0 comments
|
Download
|
|
M |
runtime/vm/malloc_hooks.h
|
View
|
|
1 chunk |
+1 line, -7 lines |
0 comments
|
Download
|
|
M |
runtime/vm/malloc_hooks.cc
|
View
|
|
1 chunk |
+4 lines, -255 lines |
0 comments
|
Download
|
|
D |
runtime/vm/malloc_hooks_test.cc
|
View
|
|
1 chunk |
+0 lines, -80 lines |
0 comments
|
Download
|
|
M |
runtime/vm/malloc_hooks_unsupported.cc
|
View
|
|
1 chunk |
+4 lines, -26 lines |
0 comments
|
Download
|
|
M |
runtime/vm/vm.gypi
|
View
|
|
4 chunks |
+28 lines, -0 lines |
0 comments
|
Download
|
|
M |
runtime/vm/vm_sources.gypi
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
Total messages: 5 (2 generated)
|
Chromium Code Reviews
Issue
2647793005:
Revert "Reintroducing MallocHooks changes with fix for infinite loop in MallocHooks on Platform::Ex… (Closed)
