Revert "Reintroducing MallocHooks changes with fix for infinite loop in MallocHooks on Platform::Ex…

runtime/vm/hash_map_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/assert.h"
 #include "vm/unit_test.h"
 #include "vm/hash_map.h"
 
 namespace dart {
 
@@ skipping 13 matching lines @@
   EXPECT(map.IsEmpty());
   TestValue v1(0);
   TestValue v2(1);
   TestValue v3(0);
   map.Insert(&v1);
   EXPECT(map.LookupValue(&v1) == &v1);
   map.Insert(&v2);
   EXPECT(map.LookupValue(&v1) == &v1);
   EXPECT(map.LookupValue(&v2) == &v2);
   EXPECT(map.LookupValue(&v3) == &v1);
-  EXPECT(map.Remove(&v1));
-  EXPECT(map.Lookup(&v1) == NULL);
-  map.Insert(&v1);
   DirectChainedHashMap<PointerKeyValueTrait<TestValue> > map2(map);
   EXPECT(map2.LookupValue(&v1) == &v1);
   EXPECT(map2.LookupValue(&v2) == &v2);
   EXPECT(map2.LookupValue(&v3) == &v1);
 }
 
 
-TEST_CASE(DirectChainedHashMapInsertRemove) {
-  DirectChainedHashMap<PointerKeyValueTrait<TestValue> > map;
-  EXPECT(map.IsEmpty());
-  TestValue v1(1);
-  TestValue v2(3);  // Note: v1, v2, v3 should have the same hash.
-  TestValue v3(5);
-
-  // Start with adding and removing the same element.
-  map.Insert(&v1);
-  EXPECT(map.LookupValue(&v1) == &v1);
-  EXPECT(map.Remove(&v1));
-  EXPECT(map.Lookup(&v1) == NULL);
-
-  // Inserting v2 first should put it at the head of the list.
-  map.Insert(&v2);
-  map.Insert(&v1);
-  EXPECT(map.LookupValue(&v2) == &v2);
-  EXPECT(map.LookupValue(&v1) == &v1);
-
-  // Check to see if removing the head of the list causes issues.
-  EXPECT(map.Remove(&v2));
-  EXPECT(map.Lookup(&v2) == NULL);
-  EXPECT(map.LookupValue(&v1) == &v1);
-
-  // Reinsert v2, which will place it at the back of the hash map list.
-  map.Insert(&v2);
-  EXPECT(map.LookupValue(&v2) == &v2);
-
-  // Remove from the back of the hash map list.
-  EXPECT(map.Remove(&v2));
-  EXPECT(map.Lookup(&v2) == NULL);
-  EXPECT(map.Remove(&v1));
-  EXPECT(map.Lookup(&v1) == NULL);
-
-  // Check to see that removing an invalid element returns false.
-  EXPECT(!map.Remove(&v1));
-
-  // One last case: remove from the middle of a hash map list.
-  map.Insert(&v1);
-  map.Insert(&v2);
-  map.Insert(&v3);
-
-  EXPECT(map.LookupValue(&v1) == &v1);
-  EXPECT(map.LookupValue(&v2) == &v2);
-  EXPECT(map.LookupValue(&v3) == &v3);
-
-  EXPECT(map.Remove(&v2));
-  EXPECT(map.LookupValue(&v1) == &v1);
-  EXPECT(map.Lookup(&v2) == NULL);
-  EXPECT(map.LookupValue(&v3) == &v3);
-
-  EXPECT(map.Remove(&v1));
-  EXPECT(map.Remove(&v3));
-
-  EXPECT(map.IsEmpty());
-}
-
-
 TEST_CASE(MallocDirectChainedHashMap) {
   MallocDirectChainedHashMap<PointerKeyValueTrait<TestValue> > map;
   EXPECT(map.IsEmpty());
   TestValue v1(0);
   TestValue v2(1);
   TestValue v3(0);
   map.Insert(&v1);
   EXPECT(map.LookupValue(&v1) == &v1);
   map.Insert(&v2);
   EXPECT(map.LookupValue(&v1) == &v1);
@@ skipping 59 matching lines @@
     }
     count++;
     sum += p->second();
   }
 
   EXPECT(count == 5);
   EXPECT(sum == 15);
 }
 
 }  // namespace dart