Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Issue 2647783002: Reland 4471855e032876c (Closed)

Created:
3 years, 11 months ago by Evan Stade
Modified:
3 years, 11 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland 4471855e032876c Without change to ASH_EXPORTs. ------------------------------------------------------------------------ Remove some ifdefs from ash since it only supports ChromeOS now. BUG=666773 Review-Url: https://codereview.chromium.org/2631623003 ------------------------------------------------------------------------ BUG=666773 Review-Url: https://codereview.chromium.org/2647783002 Cr-Commit-Position: refs/heads/master@{#444913} Committed: https://chromium.googlesource.com/chromium/src/+/bd3a851941ee14ff689f94cc0edaef35deade131

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -24 lines) Patch
M ash/display/display_configuration_controller.cc View 3 chunks +3 lines, -10 lines 0 comments Download
M ash/display/display_util.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/display/display_util.cc View 4 chunks +3 lines, -10 lines 0 comments Download
M ash/display/mirror_window_controller.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Evan Stade
3 years, 11 months ago (2017-01-19 23:30:15 UTC) #4
James Cook
lgtm
3 years, 11 months ago (2017-01-19 23:50:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2647783002/1
3 years, 11 months ago (2017-01-20 00:45:41 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 01:16:11 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bd3a851941ee14ff689f94cc0eda...

Powered by Google App Engine
This is Rietveld 408576698